Update coverage stats with branch fallback
+24
-16
@@ -1,26 +1,39 @@
|
||||
# Company & Place Data Population
|
||||
|
||||
Assets in the tracker display **company** (customer name) and **place** (city) information in the card view. These fields are populated from the MSFS Dynamics 365 extraction DB.
|
||||
Assets display **company** (customer name) and **place** (city) in the card view. These are populated from the MSFS Dynamics 365 extraction DB.
|
||||
|
||||
## How It Works
|
||||
|
||||
The migration script `scripts/populate_asset_company_place.py` maps each asset's `connect_id` through the extraction DB:
|
||||
The migration script `scripts/populate_asset_company_place.py` maps each asset's `connect_id`:
|
||||
|
||||
1. `msdyn_customerasset.hsl_connectid` matches `assets.connect_id`
|
||||
2. `msdyn_customerasset.msdyn_account!id` links to `account.accountid`
|
||||
3. `account.name` → `asset.company` and `asset.customer_name`
|
||||
4. `account.address1_city` → `asset.place`
|
||||
5. `account.address1_line1` (+ line2) → `asset.address` (only if empty)
|
||||
1. **Primary:** `connect_id` → `msdyn_customerasset.hsl_connectid` → `account` table
|
||||
- `account.name` → `company` + `customer_name`
|
||||
- `account.address1_city` → `place`
|
||||
- `account.address1_line1` (+ line2) → `address` (if empty)
|
||||
|
||||
2. **Fallback:** When the account name is empty but the connect_id prefix (first 8 chars) maps to a branch/territory name, use the territory name as company
|
||||
- e.g., `VM-05064-...` → branch cache → `"Canteen Corp/Orlando, FL"`
|
||||
|
||||
## Coverage
|
||||
|
||||
- **5,743 / 7,488** assets (~77%) have company + customer_name populated
|
||||
- **5,647 / 7,488** assets (~75%) have place (city) populated
|
||||
- The remaining ~1,745 assets have connect_ids in the extraction DB but no linked account info
|
||||
| Source | Assets | % |
|
||||
|--------|--------|---|
|
||||
| Account name from extraction DB | 5,743 | 76.7% |
|
||||
| Branch/territory fallback | 1,606 | 21.4% |
|
||||
| Still empty (no branch mapping) | 139 | 1.9% |
|
||||
| **Total** | **7,488** | **100%** |
|
||||
|
||||
Place (city): 5,647 / 7,488 assets (75.4%)
|
||||
|
||||
## Connect ID Format
|
||||
|
||||
The connect_id encodes:
|
||||
- `VM-05912-0000068454` → branch ID `5912`, machine ID `68454`
|
||||
- First 8 chars (`VM-05912`) = prefix used for branch/territory mapping
|
||||
|
||||
## Re-running
|
||||
|
||||
The script is idempotent — it only updates fields that are empty:
|
||||
The script is idempotent — only updates empty fields:
|
||||
|
||||
```bash
|
||||
cd ~/projects/canteen-asset-tracker
|
||||
@@ -30,8 +43,3 @@ python3 scripts/populate_asset_company_place.py
|
||||
## SQL Query Fix
|
||||
|
||||
The `GET /api/assets` endpoint uses `COALESCE(c.name, a.customer_name)` instead of `c.name AS customer_name` to prevent the LEFT JOIN from overriding stored customer_name with NULL when `customer_id` is not set.
|
||||
|
||||
```sql
|
||||
SELECT a.*, COALESCE(c.name, a.customer_name) AS customer_name
|
||||
FROM assets a LEFT JOIN customers c ON a.customer_id = c.id
|
||||
```
|
||||
Reference in New Issue
Block a user