• Joined on 2026-05-17
shawn pushed to main at shawn/pi-multifx-pedal 2026-06-18 22:25:12 +00:00
d7889c6f23 fix: _process_4cm handles 1D mono input gracefully
shawn pushed to main at shawn/pi-multifx-pedal 2026-06-18 22:24:01 +00:00
4039ee963d fix: restore missing import argparse
shawn pushed to main at shawn/pi-multifx-pedal 2026-06-18 22:23:02 +00:00
6495facb02 fix: disable Python garbage collector to prevent 1s periodic audio pops
shawn pushed to main at shawn/pi-multifx-pedal 2026-06-18 22:10:41 +00:00
017a74a414 fix: kill alsa_in in stop_jack; verify jackd matches config device
shawn pushed to main at shawn/pi-multifx-pedal 2026-06-18 22:08:25 +00:00
f1c6f64dc8 fix: add 1.5s stabilization check in start_jack to catch flaky JACK startup
shawn pushed to main at shawn/pi-multifx-pedal 2026-06-18 22:04:08 +00:00
32990f9744 fix: _jack_is_operational() must check jack_lsp stdout, not exit code
shawn pushed to main at shawn/pi-multifx-pedal 2026-06-18 21:59:31 +00:00
9a8c59d19c fix: replace broken jack_default_0_0 socket check with jack_lsp for JACK 1.9.22 compatibility
shawn pushed to main at shawn/pi-multifx-pedal 2026-06-18 21:54:24 +00:00
4b694cc5f8 fix: replace DC-blocking HPF with 60Hz biquad notch filter (hum fix)
shawn pushed to main at shawn/pi-multifx-pedal 2026-06-18 21:46:44 +00:00
4ad50e3588 fix: narrow SHM cleanup in profile handler to client semaphore only; add DC-blocking HPF to pipeline input (60Hz hum fix)
shawn pushed to main at shawn/pi-multifx-pedal 2026-06-18 21:29:53 +00:00
92c6bb9587 fix: stop bt-a2dp-jack during profile changes to prevent JACK race
shawn pushed to main at shawn/pi-multifx-pedal 2026-06-18 21:26:54 +00:00
61886858f6 fix: rollback must restore AudioConfig period/rate + LATENCY_PROFILES
shawn pushed to main at shawn/pi-multifx-pedal 2026-06-18 21:21:10 +00:00
f3cdf5e13b fix: multiple issues preventing NAM from surviving rate/period changes
shawn pushed to main at shawn/pi-multifx-pedal 2026-06-18 21:17:35 +00:00
c0c2538c80 fix: verify JACK is operational before returning from start_jack()
shawn pushed to main at shawn/pi-multifx-pedal 2026-06-18 21:14:36 +00:00
ce82207d03 fix: clean stale JACK SHM before client creation in profile handler
shawn pushed to main at shawn/pi-multifx-pedal 2026-06-18 03:21:16 +00:00
de5723f138 fix: update preset NAM block path when loading a model globally
shawn pushed to main at shawn/pi-multifx-pedal 2026-06-18 03:06:49 +00:00
aa0bcf35fe fix: remove auth middleware — single-user pedal doesn't need it
shawn commented on issue shawn/pi-multifx-pedal#16 2026-06-18 02:59:24 +00:00
Code Review: pi-multifx-pedal (24 findings across 13 fixes)

Additional fix: Auth PIN was generated but not served to frontend, causing 401 on all POST/PUT/DELETE endpoints (NAM select, bypass, volume, etc.). Fixed by:

  • Added auth_pin to /api/state
shawn pushed to main at shawn/pi-multifx-pedal 2026-06-18 02:59:03 +00:00
95029c6c8c fix: wire auth PIN to frontend, clean up dead constants
shawn pushed to main at shawn/pi-multifx-pedal 2026-06-18 02:51:32 +00:00
a3ec86b814 chore: remove rogue patch files from tracking
shawn pushed to main at shawn/pi-multifx-pedal 2026-06-18 02:51:25 +00:00
ad5b369a10 fix: wire auth PIN to frontend — 401 on NAM select and all POST/PUT calls