shawn/pi-multifx-pedal
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

Code Review: pi-multifx-pedal (24 findings across 13 fixes) #16

New Issue
Closed
opened 2026-06-18 02:38:55 +00:00 by shawn · 1 comment
shawn commented 2026-06-18 02:38:55 +00:00
Owner
Copy Link
Copy Source

All 24 findings from the code review resolved across 13 kanban cards.

P1: multi-channel, auth, hotspot
P2: thread safety, DSP reset, async blocking, MIDI Learn
P3: lost-update, sample rate, NAM, API cleanup
P4: code quality, docs/CI

Commits: 1603bfe 3c8d5e4 42e357c c65e481 2558306

All 24 findings from the code review resolved across 13 kanban cards. P1: multi-channel, auth, hotspot P2: thread safety, DSP reset, async blocking, MIDI Learn P3: lost-update, sample rate, NAM, API cleanup P4: code quality, docs/CI Commits: 1603bfe 3c8d5e4 42e357c c65e481 2558306
shawn closed this issue 2026-06-18 02:38:59 +00:00
shawn commented 2026-06-18 02:59:24 +00:00
Author
Owner
Copy Link
Copy Source

Additional fix: Auth PIN was generated but not served to frontend, causing 401 on all POST/PUT/DELETE endpoints (NAM select, bypass, volume, etc.). Fixed by:

  • Added auth_pin to /api/state response
  • Frontend stores PIN on initial load, includes X-Pedal-Auth header on non-GET requests
  • All 385 tests pass

Commit: 95029c6

**Additional fix:** Auth PIN was generated but not served to frontend, causing 401 on all POST/PUT/DELETE endpoints (NAM select, bypass, volume, etc.). Fixed by: - Added `auth_pin` to `/api/state` response - Frontend stores PIN on initial load, includes `X-Pedal-Auth` header on non-GET requests - All 385 tests pass Commit: 95029c6
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shawn
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shawn/pi-multifx-pedal#16
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?