shawn/pi-multifx-pedal
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(bass-presets): move factory presets to channel subdirs + per-channel install

Browse Source 
Root cause: factory presets for bass (banks 17-20) sat in the root
factory dir alongside guitar presets, and install_factory_presets()
used rglob() which picked up ALL presets into the GUITAR channel.

Changes:
- Move bank_17-20 from presets/factory/ → presets/factory/bass/
  (matching the existing keys/, vocals/, backing_tracks/ layout)
- Fix install_factory_presets() to scan channel-specific subdirectory:
  GUITAR scans root bank_* dirs, all others scan <channel>/bank_*
- Fix main.py to iterate over all 5 channels when installing factory
  presets (was only installing into GUITAR)
- Import Channel enum in main.py

Tests: 56/56 preset manager tests pass. Integration verified:
- GUITAR: 68 presets (banks 0-16)
- BASS: 16 presets (banks 17-20, SansAmp/Darkglass/Ampeg SVT)
- KEYS: 12 presets (banks 21-23)
- VOCALS: 12 presets (banks 24-26)
- BACKING_TRACKS: 12 presets (banks 27-29)
This commit is contained in:
Shawn
2026-06-13 10:23:57 -04:00
parent 575535762c
commit 659e53766a
25 changed files with 162 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
presets/factory/bass/bank_19/bank.json
+5
View File
@@ -0,0 +1,5 @@
{
"number": 19,
"name": "Bass \u2014 Modern & Metal",
"preset_count": 4
}
presets/factory/bass/bank_19/preset_0.json
+96
View File
@@ -0,0 +1,96 @@
{
"name": "Modern Metal (Darkglass B3K)",
"bank": 19,
"program": 0,
"master_volume": 0.85,
"chain": [
{
"fx_type": "noise_gate",
"enabled": true,
"bypass": false,
"params": {
"threshold": 0.008
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "compressor",
"enabled": true,
"bypass": false,
"params": {
"threshold": 0.15,
"ratio": 4.5,
"gain": 0.6
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "nam_amp",
"enabled": true,
"bypass": false,
"params": {
"level": 0.7
},
"nam_model_path": "/root/.pedal/models/Fender_Twin_Reverb_Clean_A2.nam",
"ir_file_path": ""
},
{
"fx_type": "ir_cab",
"enabled": true,
"bypass": false,
"params": {
"wet": 1.0,
"dry": 0.0
},
"nam_model_path": "",
"ir_file_path": "/root/.pedal/irs/bass-clanky.wav"
},
{
"fx_type": "eq",
"enabled": true,
"bypass": false,
"params": {
"bass": 0.5,
"mid": 0.6,
"treble": 0.4
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "distortion",
"enabled": true,
"bypass": false,
"params": {
"drive": 0.55,
"tone": 0.5,
"level": 0.75
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "noise_gate",
"enabled": true,
"bypass": false,
"params": {
"threshold": 0.04
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "volume",
"enabled": true,
"bypass": false,
"params": {
"level": 0.88
},
"nam_model_path": "",
"ir_file_path": ""
}
],
"midi_mappings": {}
}
presets/factory/bass/bank_19/preset_1.json
+96
View File
@@ -0,0 +1,96 @@
{
"name": "Djent Bass (Darkglass AO)",
"bank": 19,
"program": 1,
"master_volume": 0.83,
"chain": [
{
"fx_type": "noise_gate",
"enabled": true,
"bypass": false,
"params": {
"threshold": 0.008
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "compressor",
"enabled": true,
"bypass": false,
"params": {
"threshold": 0.18,
"ratio": 4.0,
"gain": 0.55
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "nam_amp",
"enabled": true,
"bypass": false,
"params": {
"level": 0.68
},
"nam_model_path": "/root/.pedal/models/Fender_Twin_Reverb_Clean_A2.nam",
"ir_file_path": ""
},
{
"fx_type": "ir_cab",
"enabled": true,
"bypass": false,
"params": {
"wet": 1.0,
"dry": 0.0
},
"nam_model_path": "",
"ir_file_path": "/root/.pedal/irs/bass-half_and_half.wav"
},
{
"fx_type": "eq",
"enabled": true,
"bypass": false,
"params": {
"bass": 0.4,
"mid": 0.55,
"treble": 0.3
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "distortion",
"enabled": true,
"bypass": false,
"params": {
"drive": 0.5,
"tone": 0.35,
"level": 0.7
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "noise_gate",
"enabled": true,
"bypass": false,
"params": {
"threshold": 0.05
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "volume",
"enabled": true,
"bypass": false,
"params": {
"level": 0.85
},
"nam_model_path": "",
"ir_file_path": ""
}
],
"midi_mappings": {}
}
presets/factory/bass/bank_19/preset_2.json
+111
View File
@@ -0,0 +1,111 @@
{
"name": "Thrash Attack (Cliff Burton)",
"bank": 19,
"program": 2,
"master_volume": 0.88,
"chain": [
{
"fx_type": "noise_gate",
"enabled": true,
"bypass": false,
"params": {
"threshold": 0.006
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "compressor",
"enabled": true,
"bypass": false,
"params": {
"threshold": 0.2,
"ratio": 3.5,
"gain": 0.5
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "nam_amp",
"enabled": true,
"bypass": false,
"params": {
"level": 0.78
},
"nam_model_path": "/root/.pedal/models/JCM2000_Crunch.nam",
"ir_file_path": ""
},
{
"fx_type": "ir_cab",
"enabled": true,
"bypass": false,
"params": {
"wet": 1.0,
"dry": 0.0
},
"nam_model_path": "",
"ir_file_path": "/root/.pedal/irs/bass-rumble_bass.wav"
},
{
"fx_type": "eq",
"enabled": true,
"bypass": false,
"params": {
"bass": 0.6,
"mid": 0.5,
"treble": 0.5
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "distortion",
"enabled": true,
"bypass": false,
"params": {
"drive": 0.65,
"tone": 0.45,
"level": 0.8
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "auto_wah",
"enabled": true,
"bypass": false,
"params": {
"sensitivity": 0.3,
"resonance": 0.4,
"min_frequency": 0.2,
"max_frequency": 0.7
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "reverb",
"enabled": true,
"bypass": false,
"params": {
"subtype": "hall",
"decay": 0.5,
"mix": 0.2
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "volume",
"enabled": true,
"bypass": false,
"params": {
"level": 0.9
},
"nam_model_path": "",
"ir_file_path": ""
}
],
"midi_mappings": {}
}
presets/factory/bass/bank_19/preset_3.json
+98
View File
@@ -0,0 +1,98 @@
{
"name": "Nu-Metal Growl (Fieldy / Tim C)",
"bank": 19,
"program": 3,
"master_volume": 0.86,
"chain": [
{
"fx_type": "noise_gate",
"enabled": true,
"bypass": false,
"params": {
"threshold": 0.008
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "compressor",
"enabled": true,
"bypass": false,
"params": {
"threshold": 0.2,
"ratio": 4.0,
"gain": 0.6
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "nam_amp",
"enabled": true,
"bypass": false,
"params": {
"level": 0.7
},
"nam_model_path": "/root/.pedal/models/Fender_Deluxe_Reverb_A2.nam",
"ir_file_path": ""
},
{
"fx_type": "ir_cab",
"enabled": true,
"bypass": false,
"params": {
"wet": 1.0,
"dry": 0.0
},
"nam_model_path": "",
"ir_file_path": "/root/.pedal/irs/bass-thick_classic.wav"
},
{
"fx_type": "eq",
"enabled": true,
"bypass": false,
"params": {
"bass": 0.7,
"mid": 0.35,
"treble": 0.4
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "distortion",
"enabled": true,
"bypass": false,
"params": {
"drive": 0.6,
"tone": 0.3,
"level": 0.8
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "overdrive",
"enabled": true,
"bypass": false,
"params": {
"drive": 0.3,
"tone": 0.25,
"level": 0.6
},
"nam_model_path": "",
"ir_file_path": ""
},
{
"fx_type": "volume",
"enabled": true,
"bypass": false,
"params": {
"level": 0.88
},
"nam_model_path": "",
"ir_file_path": ""
}
],
"midi_mappings": {}
}