fix(bass-presets): move factory presets to channel subdirs + per-channel install

Root cause: factory presets for bass (banks 17-20) sat in the root factory dir alongside guitar presets, and install_factory_presets() used rglob() which picked up ALL presets into the GUITAR channel. Changes: - Move bank_17-20 from presets/factory/ → presets/factory/bass/ (matching the existing keys/, vocals/, backing_tracks/ layout) - Fix install_factory_presets() to scan channel-specific subdirectory: GUITAR scans root bank_* dirs, all others scan <channel>/bank_* - Fix main.py to iterate over all 5 channels when installing factory presets (was only installing into GUITAR) - Import Channel enum in main.py Tests: 56/56 preset manager tests pass. Integration verified: - GUITAR: 68 presets (banks 0-16) - BASS: 16 presets (banks 17-20, SansAmp/Darkglass/Ampeg SVT) - KEYS: 12 presets (banks 21-23) - VOCALS: 12 presets (banks 24-26) - BACKING_TRACKS: 12 presets (banks 27-29)
2026-06-13 10:23:57 -04:00
parent 575535762c
commit 659e53766a
25 changed files with 162 additions and 10 deletions
@@ -0,0 +1,110 @@
+{
+  "name": "Jazz Fusion (Marcus Miller)",
+  "bank": 17,
+  "program": 2,
+  "master_volume": 0.8,
+  "chain": [
+    {
+      "fx_type": "noise_gate",
+      "enabled": true,
+      "bypass": false,
+      "params": {
+        "threshold": 0.005
+      },
+      "nam_model_path": "",
+      "ir_file_path": ""
+    },
+    {
+      "fx_type": "compressor",
+      "enabled": true,
+      "bypass": false,
+      "params": {
+        "threshold": 0.3,
+        "ratio": 2.5,
+        "gain": 0.4
+      },
+      "nam_model_path": "",
+      "ir_file_path": ""
+    },
+    {
+      "fx_type": "nam_amp",
+      "enabled": true,
+      "bypass": false,
+      "params": {
+        "level": 0.72
+      },
+      "nam_model_path": "/root/.pedal/models/Fender_Deluxe_Reverb_A2.nam",
+      "ir_file_path": ""
+    },
+    {
+      "fx_type": "ir_cab",
+      "enabled": true,
+      "bypass": false,
+      "params": {
+        "wet": 1.0,
+        "dry": 0.0
+      },
+      "nam_model_path": "",
+      "ir_file_path": "/root/.pedal/irs/bass-more_mids.wav"
+    },
+    {
+      "fx_type": "eq",
+      "enabled": true,
+      "bypass": false,
+      "params": {
+        "bass": 0.5,
+        "mid": 0.6,
+        "treble": 0.5
+      },
+      "nam_model_path": "",
+      "ir_file_path": ""
+    },
+    {
+      "fx_type": "overdrive",
+      "enabled": true,
+      "bypass": false,
+      "params": {
+        "drive": 0.25,
+        "tone": 0.55,
+        "level": 0.6
+      },
+      "nam_model_path": "",
+      "ir_file_path": ""
+    },
+    {
+      "fx_type": "chorus",
+      "enabled": true,
+      "bypass": false,
+      "params": {
+        "rate": 0.4,
+        "depth": 0.35,
+        "mix": 0.25
+      },
+      "nam_model_path": "",
+      "ir_file_path": ""
+    },
+    {
+      "fx_type": "reverb",
+      "enabled": true,
+      "bypass": false,
+      "params": {
+        "subtype": "hall",
+        "decay": 0.5,
+        "mix": 0.25
+      },
+      "nam_model_path": "",
+      "ir_file_path": ""
+    },
+    {
+      "fx_type": "volume",
+      "enabled": true,
+      "bypass": false,
+      "params": {
+        "level": 0.85
+      },
+      "nam_model_path": "",
+      "ir_file_path": ""
+    }
+  ],
+  "midi_mappings": {}
+}