fix: 'Bank @' → 'Bank A' (off-by-one in transport mode bank letter gen)

Browse Source

Two issues found and fixed in the deployed UI bundle:

1. String.fromCharCode(64+y) where y is 0-based bank index
   → 64+y gives 64+0=64 = '@' for bank 0
   → Fixed: 65+y gives 65+0=65 = 'A' for bank 0

2. e.bank||1 where falsy 0 falls through to 1
   → Shows 'Bank 1' for bank 0, 'Bank 2' for bank 1
   → Fixed: e.bank||0 so 0 renders as 'Bank 0'

Source code (frontend-react/src/App.jsx) was already clean —
the bug was in a transport/song mode feature that was built
from uncommitted changes then reverted.

...

This commit is contained in:

Shawn

2026-06-13 10:17:44 -04:00

parent 42d0592856

commit 4b59e4422c

2 changed files with 0 additions and 200 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

src/web/ui-dist/assets/index-BTj9vC7e.js

-100

File diff suppressed because one or more lines are too long

src/web/ui-dist/assets/index-CV8EM6Xu.js

-100

File diff suppressed because one or more lines are too long