fix: code review batch 2 — multi-channel, thread safety, DSP reset, MIDI, hotspot, NAM, docs/CI, code quality

scripts/benchmark_fx.py

@@ -20,7 +20,7 @@ import time
 
 import numpy as np
 
-from src.dsp.pipeline import AudioPipeline, BLOCK_SIZE, SAMPLE_RATE
+from src.dsp.pipeline import AudioPipeline
 from src.presets.types import FXBlock, FXType, Preset
 
 # ── Test tone parameters ───────────────────────────────────────────

scripts/setup-mdns.sh

@@ -10,7 +10,7 @@
 # 4. Installs the service advertisement file for the web UI
 # 5. Restarts avahi-daemon
 #
-# After this, http://pedal.local:8080 works from any machine on the LAN.
+# After this, http://pedal.local works from any machine on the LAN.
 # ───────────────────────────────────────────────────────────────────────
 
 set -euo pipefail
@@ -71,11 +71,11 @@ sudo systemctl restart avahi-daemon
 echo ""
 echo "═══ mDNS setup complete ═══"
 echo "The pedal should now be reachable at:"
-echo "  http://${HOSTNAME}.local:8080"
+echo "  http://${HOSTNAME}.local"
 echo ""
 echo "From any device on the same LAN, try:"
 echo "  ping ${HOSTNAME}.local"
-echo "  curl http://${HOSTNAME}.local:8080/api/state"
+echo "  curl http://${HOSTNAME}.local/api/state"
 echo ""
 echo "NOTE: If resolution doesn't work immediately, wait ~10 seconds"
 echo "for mDNS propagation, or check: sudo systemctl status avahi-daemon"

scripts/setup-wifi-ap.sh

@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 # ── Pi Multi-FX Pedal — WiFi Access Point Setup ────────────────────
 # Enables the Pi to act as its own WiFi hotspot.
-# Phone connects to "Pi-Pedal" → web UI at http://pedal.local:8080
+# Phone connects to "Pi-Pedal" → web UI at http://pedal.local
 # No venue WiFi or internet required.
 #
 # Usage:
@@ -11,7 +11,7 @@
 #
 # After setup:
 #   Phone WiFi → join "Pi-Pedal" (password: changeme or your custom psk)
-#   Browser → http://pedal.local:8080
+#   Browser → http://pedal.local
 #
 # Dual WiFi option (for internet while hotspot is active):
 #   Plug a USB WiFi dongle. The built-in WiFi becomes the hotspot,
@@ -25,7 +25,7 @@ PROJECT_DIR="$(dirname "$SCRIPT_DIR")"
 
 # ── Defaults ──────────────────────────────────────────────────────────
 SSID="Pi-Pedal"
-PSK="pedal1234"
+PSK="$(head -c 12 /dev/urandom | base64 | tr -dc 'A-Za-z0-9' | head -c 12)"
 AP_IP="192.168.4.1"
 DISABLE=false
 
@@ -206,8 +206,8 @@ echo "╚═══════════════════════
 echo ""
 echo "  📶 SSID:     $SSID"
 echo "  🔑 Password: $PSK"
-echo "  🔗 Web UI:   http://pedal.local:8080"
-echo "  🌐 IP:       http://$AP_IP:8080"
+echo "  🔗 Web UI:   http://pedal.local"
+echo "  🌐 IP:       http://$AP_IP"
 echo ""
 echo "Your phone should see '$SSID' in available WiFi networks."
 echo "Join it, then open the browser to the URL above."