fix: code review batch 2 — multi-channel, thread safety, DSP reset, MIDI, hotspot, NAM, docs/CI, code quality
CI / test (push) Has been cancelled
CI / test (push) Has been cancelled
This commit is contained in:
@@ -2,7 +2,7 @@
|
||||
|
||||
## Scope
|
||||
|
||||
Test every block-related API endpoint and the UI's interaction with it. Covers both the React SPA at `pedal.local:8080` and the REST/WebSocket APIs.
|
||||
Test every block-related API endpoint and the UI's interaction with it. Covers both the React SPA at `pedal.local` and the REST/WebSocket APIs.
|
||||
|
||||
---
|
||||
|
||||
@@ -99,7 +99,7 @@ Core bug: previously `enabled` changed but `bypass` stayed true, so blocks remai
|
||||
|
||||
| # | Test | Action | Expected | Result |
|
||||
|---|------|--------|----------|--------|
|
||||
| 7.1 | Connect WS | `wscat -c ws://pedal.local:8080/ws` | Receives `{"type": "connected", "state": {...}}` |
|
||||
| 7.1 | Connect WS | `wscat -c ws://pedal.local/ws` | Receives `{"type": "connected", "state": {...}}` |
|
||||
| 7.2 | Ping/pong | Send `{"type": "ping"}` | Response `{"type": "pong"}` |
|
||||
| 7.3 | Block toggle broadcast | Toggle block via PATCH /api/blocks | WS message `{"type": "block_toggled", ...}` |
|
||||
| 7.4 | Preset change broadcast | Activate preset via API | WS message `{"type": "preset_changed", ...}` |
|
||||
@@ -113,7 +113,7 @@ Core bug: previously `enabled` changed but `bypass` stayed true, so blocks remai
|
||||
|
||||
| # | Test | Action | Expected | Result |
|
||||
|---|------|--------|----------|--------|
|
||||
| 8.1 | Page loads | Navigate to `http://pedal.local:8080/` | React SPA renders, block chain visible |
|
||||
| 8.1 | Page loads | Navigate to `http://pedal.local/` | React SPA renders, block chain visible |
|
||||
| 8.2 | NAM block visible | Check the block chain | "nam_amp" tile shown with correct icon |
|
||||
| 8.3 | Block label | Read tile text | Shows "nam_amp" or friendly name |
|
||||
| 8.4 | Toggle block ON/OFF | Click the block's power icon | Block appears enabled/disabled visually |
|
||||
@@ -162,12 +162,12 @@ Run in order. Mark each cell:
|
||||
For curl tests, use this template:
|
||||
|
||||
```bash
|
||||
curl -sv http://pedal.local:8080/api/presets | python3 -m json.tool
|
||||
curl -sv http://pedal.local/api/presets | python3 -m json.tool
|
||||
```
|
||||
|
||||
For WS tests:
|
||||
|
||||
```bash
|
||||
# Connect, wait, then send toggle commands in another terminal
|
||||
wscat -c ws://pedal.local:8080/ws
|
||||
wscat -c ws://pedal.local/ws
|
||||
```
|
||||
|
||||
Reference in New Issue
Block a user