Large file uploads to temporary file

src/CMakeLists.txt

@@ -131,6 +131,7 @@ else()
 endif()
 
 set (PIPEDAL_SOURCES
+    TemporaryFile.cpp TemporaryFile.hpp     
     FilePropertyDirectoryTree.cpp FilePropertyDirectoryTree.hpp 
     FileEntry.cpp FileEntry.hpp
     atom_object.hpp atom_object.cpp

src/PiPedalModel.cpp

@@ -2081,9 +2081,9 @@ FilePropertyDirectoryTree::ptr PiPedalModel::GetFilePropertydirectoryTree(const
 }
 
 
-std::string PiPedalModel::UploadUserFile(const std::string &directory, const std::string &patchProperty, const std::string &filename, const std::string &fileBody)
+std::string PiPedalModel::UploadUserFile(const std::string &directory, const std::string &patchProperty, const std::string &filename, std::istream&stream, size_t contentLength)
 {
-    return storage.UploadUserFile(directory, patchProperty, filename, fileBody);
+    return storage.UploadUserFile(directory, patchProperty, filename, stream,contentLength);
 }
 
 uint64_t PiPedalModel::CreateNewPreset()

src/PiPedalModel.hpp

@@ -336,7 +336,7 @@ namespace pipedal
         std::string RenameFilePropertyFile(const std::string&oldRelativePath,const std::string&newRelativePath,const UiFileProperty&uiFileProperty);
         FilePropertyDirectoryTree::ptr GetFilePropertydirectoryTree(const UiFileProperty&uiFileProperty);
 
-        std::string UploadUserFile(const std::string &directory, const std::string &patchProperty,const std::string&filename,const std::string&fileBody);
+        std::string UploadUserFile(const std::string &directory, const std::string &patchProperty,const std::string&filename,std::istream&inputStream,size_t streamLength);
         uint64_t CreateNewPreset();
 
         bool LoadCurrentPedalboard();

src/Storage.cpp

@@ -1678,7 +1678,7 @@ void Storage::DeleteSampleFile(const std::filesystem::path &fileName)
 }
 std::filesystem::path Storage::MakeUserFilePath(const std::string &directory, const std::string &filename)
 {
-    if (!UiFileProperty::IsDirectoryNameValid(directory))
+    if (!ensureNoDotDot(directory))
     {
         throw std::logic_error("Permission denied.");
     }
@@ -1695,7 +1695,7 @@ std::filesystem::path Storage::MakeUserFilePath(const std::string &directory, co
     }
     return result;
 }
-std::string Storage::UploadUserFile(const std::string &directory, const std::string &patchProperty, const std::string &filename, const std::string &fileBody)
+std::string Storage::UploadUserFile(const std::string &directory, const std::string &patchProperty, const std::string &filename, std::istream&stream, size_t contentLength)
 {
     std::filesystem::path path;
     if (directory.length() != 0)
@@ -1720,10 +1720,28 @@ std::string Storage::UploadUserFile(const std::string &directory, const std::str
             {
                 throw std::logic_error(SS("Can't create file " << path << "."));
             }
-            f.write(fileBody.c_str(), fileBody.length());
+            std::vector<uint8_t> buffer;
+            size_t BUFFER_SIZE = 64*1024;
+            buffer.resize(BUFFER_SIZE);
+            char *pBuffer= (char*)&(buffer[0]);
+            while (contentLength != 0)
+            {
+                size_t thisTime = std::min(BUFFER_SIZE,contentLength);
+                stream.read(pBuffer,(std::streamsize)thisTime);
+                if (!stream) {
+                    throw std::runtime_error("Unable to read body input stream.");
+                }
+                f.write(pBuffer,(std::streamsize)thisTime);
+                if (!f) {
+                    throw std::runtime_error("Failed to write to upload file.");
+                }
+                contentLength -= thisTime;
+            }
         } catch (const std::exception &e)
         {
             Lv2Log::error(SS("Upload failed. " << e.what()));
+            std::filesystem::remove(path);
+            throw;
         }
     }
     return path.string();

src/Storage.hpp

@@ -218,7 +218,7 @@ public:
     void SetSystemMidiBindings(const std::vector<MidiBinding>&bindings);
     std::vector<MidiBinding> GetSystemMidiBindings();
     void DeleteSampleFile(const std::filesystem::path &fileName);
-    std::string UploadUserFile(const std::string &directory, const std::string &patchProperty,const std::string&filename,const std::string&fileBody);
+    std::string UploadUserFile(const std::string &directory, const std::string &patchProperty,const std::string&filename,std::istream&stream, size_t contentLength);
     std::string CreateNewSampleDirectory(const std::string&relativePath, const UiFileProperty&uiFileProperty);
     std::string RenameFilePropertyFile(
         const std::string&oldRelativePath,

src/TemporaryFile.cpp

@@ -0,0 +1,61 @@
+// Copyright (c) 2024 Robin Davies
+//
+// Permission is hereby granted, free of charge, to any person obtaining a copy of
+// this software and associated documentation files (the "Software"), to deal in
+// the Software without restriction, including without limitation the rights to
+// use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
+// the Software, and to permit persons to whom the Software is furnished to do so,
+// subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in all
+// copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
+// FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
+// COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
+// IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
+// CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+#include "TemporaryFile.hpp"
+
+using namespace pipedal;
+
+
+TemporaryFile::TemporaryFile(const std::filesystem::path&directory)
+{
+    namespace fs = std::filesystem;
+    fs::create_directories(directory);
+
+    // Generate a unique filename
+    std::string filename;
+    do {
+        std::string random_string(8, '\0');
+        const char alphanum[] = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
+        
+        srand(static_cast<unsigned int>(time(nullptr)));
+        for (int i = 0; i < 8; ++i) {
+            random_string[i] = alphanum[rand() % (sizeof(alphanum) - 1)];
+        }
+        
+        filename = directory / ("temp_" + random_string + ".tmp");
+    } while (fs::exists(filename));
+
+    // Create the file
+    std::ofstream file(filename);
+    if (!file) {
+        throw std::runtime_error("Failed to create temporary file");
+    }
+    file.close();
+
+    this->path = filename;
+
+}
+TemporaryFile::~TemporaryFile()
+{
+    if (!path.empty())
+    {
+        std::filesystem::remove(path);
+    }
+}
+

src/TemporaryFile.hpp

@@ -0,0 +1,34 @@
+// Copyright (c) 2024 Robin Davies
+//
+// Permission is hereby granted, free of charge, to any person obtaining a copy of
+// this software and associated documentation files (the "Software"), to deal in
+// the Software without restriction, including without limitation the rights to
+// use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
+// the Software, and to permit persons to whom the Software is furnished to do so,
+// subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in all
+// copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
+// FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
+// COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
+// IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
+// CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+#pragma once
+#include <filesystem>
+namespace pipedal {
+    class TemporaryFile {
+    public:
+        TemporaryFile(const TemporaryFile&) = delete;
+        TemporaryFile&operator=(const TemporaryFile&) = delete;
+
+        TemporaryFile(const std::filesystem::path&parentDirectory);
+        ~TemporaryFile();
+        const std::filesystem::path&Path()const { return path;}
+    private:
+        std::filesystem::path path;
+    };
+}

src/WebServer.cpp

@@ -1,3 +1,21 @@
+// Copyright (c) 2022-2024 Robin Davies
+//
+// Permission is hereby granted, free of charge, to any person obtaining a copy of
+// this software and associated documentation files (the "Software"), to deal in
+// the Software without restriction, including without limitation the rights to
+// use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
+// the Software, and to permit persons to whom the Software is furnished to do so,
+// subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in all
+// copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
+// FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
+// COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
+// IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
+// CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 #include "pch.h"
 
@@ -28,29 +46,467 @@
 #include <websocketpp/server.hpp>
 
 #include "WebServerLog.hpp"
+#include "TemporaryFile.hpp"
 
 using namespace pipedal;
 using namespace std;
 
 const bool ENABLE_KEEP_ALIVE = true;
+const std::filesystem::path WEB_TEMP_DIR{"/var/pipedal/web_temp"};
 
 using tcp = boost::asio::ip::tcp; // from <boost/asio/ip/tcp.hpp>
 
-const size_t MAX_READ_SIZE = 1 * 1024 * 204;
+const size_t MAX_READ_SIZE = 512 * 1024 * 1024;;
 using namespace boost;
 
-class CustomPpConfig: public websocketpp::config::asio {
+class request_with_file_upload : public websocketpp::http::parser::parser
+{
+public:
+    using super = websocketpp::http::parser::parser;
+
+    typedef request_with_file_upload type;
+    typedef std::shared_ptr<type> ptr;
+
+    request_with_file_upload()
+        : m_buf(std::make_shared<std::string>()), m_ready(false) {}
+
+    size_t consume(char const *buf, size_t len, std::error_code &ec);
+
+    /// Returns whether or not the request is ready for reading.
+    bool ready() const
+    {
+        return m_ready;
+    }
+    std::istream&get_body_input_stream();
+    size_t content_length() const  { return m_content_length;}
+
+    /// Returns the full raw request (including the body)
+    std::string raw() const;
+
+    /// Returns the raw request headers only (similar to an HTTP HEAD request)
+    std::string raw_head() const;
+
+    /// Set the HTTP method.
+    /**
+     * Must be a valid HTTP token
+     *
+     * @since 0.9.0 added return value and removed exception
+     *
+     * @param [in] method The value to set the method to.
+     * @return A status code describing the outcome of the operation.
+     */
+    std::error_code set_method(std::string const &method);
+
+    /// Return the request method
+    std::string const &get_method() const
+    {
+        return m_method;
+    }
+
+    /// Set the HTTP uri.
+    /**
+     * Must be a valid HTTP uri
+     *
+     * @since 0.9.0 Return value added
+     *
+     * @param uri The URI to set
+     * @return A status code describing the outcome of the operation.
+     */
+    std::error_code set_uri(std::string const &uri);
+
+    /// Return the requested URI
+    std::string const &get_uri() const
+    {
+        return m_uri;
+    }
+    /// Helper function for message::consume. Process request line
+    /**
+     * @since 0.9.0 (ec parameter added, exceptions removed)
+     *
+     * @param [in] begin An iterator to the beginning of the sequence.
+     * @param [in] end An iterator to the end of the sequence.
+     * @return A status code describing the outcome of the operation.
+     */
+
+    bool prepare_body(std::error_code &ec);
+
+    std::error_code process(std::string::iterator begin, std::string::iterator end);
+    size_t process_body(char const *buf, size_t len,
+                        std::error_code &ec);
+    std::shared_ptr<std::string> m_buf;
+    std::string m_method;
+    std::string m_uri;
+    size_t m_content_length;
+    bool m_ready;
+    bool m_uploading_to_file = false;
+    size_t m_max_in_memory_upload = 1 ; // 1 MiB
+    std::shared_ptr<TemporaryFile> m_temporaryFile;
+    std::ofstream m_outputStream;
+    std::ifstream m_inputStream;
+    std::stringstream m_stringInputStream;
+    bool m_outputOpen = false;
+};
+std::istream&request_with_file_upload::get_body_input_stream()
+{
+    if (!m_outputOpen)
+    {
+        m_outputOpen = true;
+        if (m_uploading_to_file)
+        {
+            m_inputStream.open(this->m_temporaryFile->Path(),std::ios_base::in | std::ios_base::binary);
+            return m_inputStream;
+        }else {
+            auto body = super::get_body();
+            m_stringInputStream.write(body.c_str(),body.length());
+            m_stringInputStream.flush();
+            m_stringInputStream.seekg(0);
+            return m_stringInputStream;
+        }
+    } else {
+        if (m_uploading_to_file)
+        {
+            return m_inputStream;
+        } else {
+            return m_stringInputStream;
+        }
+    }
+}
+bool request_with_file_upload::prepare_body(std::error_code &ec)
+{
+    using namespace websocketpp::http;
+    bool result = super::prepare_body(ec);
+    m_content_length = 0;
+    if (!result)
+        return result;
+    m_content_length = m_body_bytes_needed;
+    if (m_body_bytes_needed > m_max_in_memory_upload)
+    {
+        m_uploading_to_file = true;
+        try
+        {
+            this->m_temporaryFile = std::make_shared<TemporaryFile>(WEB_TEMP_DIR);
+            m_outputStream.open(this->m_temporaryFile->Path(),std::ios_base::trunc | std::ios_base::out | std::ios_base::binary);
+            if (!m_outputStream)
+            {
+                throw std::runtime_error(SS("Unable to open file " << this->m_temporaryFile->Path()));
+            }
+        }
+        catch (const std::exception &e)
+        {
+            Lv2Log::error(SS("Unabe to create upload file. " << e.what()));
+            ec = error::make_error_code(error::istream_bad);
+        }
+    }
+    return true;
+}
+
+inline size_t request_with_file_upload::process_body(char const *buf, size_t len,
+                                                     std::error_code &ec)
+{
+    using namespace websocketpp::http;
+    using namespace websocketpp::http::parser;
+
+    if (!this->m_uploading_to_file)
+    {
+        return super::process_body(buf, len, ec);
+    }
+    if (m_body_encoding == body_encoding::plain)
+    {
+        size_t processed = (std::min)(m_body_bytes_needed, len);
+        try {
+                m_outputStream.write(buf,processed);
+        } catch (const std::exception &e)
+    {
+            Lv2Log::error(SS("Can't write to web temporary file " << m_temporaryFile->Path() << ". " << e.what()));
+            ec = error::make_error_code(error::istream_bad);
+            return 0;
+        }
+        m_body_bytes_needed -= processed;
+        ec = std::error_code();
+        return processed;
+    }
+    else if (m_body_encoding == body_encoding::chunked)
+    {
+        ec = error::make_error_code(error::unsupported_transfer_encoding);
+        return 0;
+        // TODO: support for chunked transfers?
+    }
+    else
+    {
+        ec = error::make_error_code(error::unknown_transfer_encoding);
+        return 0;
+    }
+}
+
+inline size_t request_with_file_upload::consume(char const *buf, size_t len, std::error_code &ec)
+{
+    using namespace websocketpp::http;
+
+    size_t bytes_processed = 0;
+
+    if (m_ready)
+    {
+        // the request is already complete. End immediately without reading.
+        ec = std::error_code();
+        return 0;
+    }
+
+    if (m_body_bytes_needed > 0)
+    {
+        // The headers are complete, but we are still expecting more body
+        // bytes. Process body bytes.
+        bytes_processed = process_body(buf, len, ec);
+        if (ec)
+        {
+            return bytes_processed;
+        }
+
+        // if we have ready all the expected body bytes set the ready flag
+        if (body_ready())
+        {
+            m_outputStream.close();
+            m_ready = true;
+        }
+        return bytes_processed;
+    }
+
+    // at this point we have an incomplete request still waiting for headers
+
+    // copy new candidate bytes into our local buffer. This buffer may have
+    // leftover bytes from previous calls. Not all of these bytes are
+    // necessarily header bytes (they might be body or even data after this
+    // request entirely for a keepalive request)
+    m_buf->append(buf, len);
+
+    // Search for delimiter in buf. If found read until then. If not read all
+    std::string::iterator begin = m_buf->begin();
+    std::string::iterator end;
+
+    for (;;)
+    {
+        // search for line delimiter in our local buffer
+        end = std::search(
+            begin,
+            m_buf->end(),
+            header_delimiter,
+            header_delimiter + sizeof(header_delimiter) - 1);
+
+        if (end == m_buf->end())
+        {
+            // we didn't find the delimiter
+
+            // check that the confirmed header bytes plus the outstanding
+            // candidate bytes do not put us over the header size limit.
+            if (m_header_bytes + (end - begin) > max_header_size)
+            {
+                ec = error::make_error_code(error::request_header_fields_too_large);
+                return 0;
+            }
+
+            // We are out of bytes but not over any limits yet. Discard the
+            // processed bytes and copy the remaining unprecessed bytes to the
+            // beginning of the buffer in prep for another call to consume.
+
+            // If there are no processed bytes in the buffer right now don't
+            // copy the unprocessed ones over themselves.
+            if (begin != m_buf->begin())
+            {
+                std::copy(begin, end, m_buf->begin());
+                m_buf->resize(static_cast<std::string::size_type>(end - begin));
+            }
+
+            ec = std::error_code();
+            return len;
+        }
+
+        // at this point we have found a delimiter and the range [begin,end)
+        // represents a line to be processed
+
+        // update count of header bytes read so far
+        m_header_bytes += (end - begin + sizeof(header_delimiter));
+
+        if (m_header_bytes > max_header_size)
+        {
+            // This read exceeded max header size
+            ec = error::make_error_code(error::request_header_fields_too_large);
+            return 0;
+        }
+
+        if (end - begin == 0)
+        {
+            // we got a blank line, which indicates the end of the headers
+
+            // If we never got a valid method or are missing a host header then
+            // this request is invalid.
+            if (m_method.empty() || get_header("Host").empty())
+            {
+                ec = error::make_error_code(error::incomplete_request);
+                return 0;
+            }
+
+            // any bytes left over in the local buffer are bytes we didn't use.
+            // When we report how many bytes we consumed we need to subtract
+            // these so the caller knows that they need to be processed by some
+            // other logic.
+            bytes_processed = (len - static_cast<std::string::size_type>(m_buf->end() - end) + sizeof(header_delimiter) - 1);
+
+            // frees memory used temporarily during request parsing
+            m_buf.reset();
+
+            // if this was not an upgrade request and has a content length
+            // continue capturing content-length bytes and expose them as a
+            // request body.
+
+            bool need_more = prepare_body(ec);
+            if (ec)
+            {
+                return 0;
+            }
+
+            if (need_more)
+            {
+                bytes_processed += process_body(buf + bytes_processed, len - bytes_processed, ec);
+                if (ec)
+                {
+                    return 0;
+                }
+                if (body_ready())
+                {
+                    m_ready = true;
+                }
+                ec = std::error_code();
+                return bytes_processed;
+            }
+            else
+            {
+                m_ready = true;
+
+                // return number of bytes processed (starting bytes - bytes left)
+                ec = std::error_code();
+                return bytes_processed;
+            }
+        }
+        else
+        {
+            // we got a line with content
+            if (m_method.empty())
+            {
+                // if we haven't found a method yet process this line as a first line
+                ec = this->process(begin, end);
+            }
+            else
+            {
+                // this is a second (or later) line, process as a header
+                ec = this->process_header(begin, end);
+            }
+            if (ec)
+            {
+                return 0;
+            }
+        }
+
+        // if we got here it means there is another header line to read.
+        // advance our cursor to the first character after the most recent
+        // delimiter found.
+        begin = end + (sizeof(header_delimiter) - 1);
+    }
+}
+
+inline std::string request_with_file_upload::raw() const
+{
+    // TODO: validation. Make sure all required fields have been set?
+    std::stringstream ret;
+
+    ret << m_method << " " << m_uri << " " << get_version() << "\r\n";
+    ret << raw_headers() << "\r\n"
+        << m_body;
+
+    return ret.str();
+}
+
+inline std::string request_with_file_upload::raw_head() const
+{
+    // TODO: validation. Make sure all required fields have been set?
+    std::stringstream ret;
+
+    ret << m_method << " " << m_uri << " " << get_version() << "\r\n";
+    ret << raw_headers() << "\r\n";
+
+    return ret.str();
+}
+
+inline std::error_code request_with_file_upload::set_method(std::string const &method)
+{
+    using namespace websocketpp::http;
+
+    if (std::find_if(method.begin(), method.end(), is_not_token_char) != method.end())
+    {
+        return error::make_error_code(error::invalid_format);
+    }
+
+    m_method = method;
+    return std::error_code();
+}
+
+inline std::error_code request_with_file_upload::set_uri(std::string const &uri)
+{
+    // TODO: validation?
+    m_uri = uri;
+
+    return std::error_code();
+}
+
+inline std::error_code request_with_file_upload::process(std::string::iterator begin, std::string::iterator
+                                                                                          end)
+{
+    using namespace websocketpp::http;
+    std::error_code ec;
+
+    std::string::iterator cursor_start = begin;
+    std::string::iterator cursor_end = std::find(begin, end, ' ');
+
+    if (cursor_end == end)
+    {
+        return error::make_error_code(error::incomplete_request);
+    }
+
+    ec = set_method(std::string(cursor_start, cursor_end));
+    if (ec)
+    {
+        return ec;
+    }
+
+    cursor_start = cursor_end + 1;
+    cursor_end = std::find(cursor_start, end, ' ');
+
+    if (cursor_end == end)
+    {
+        return error::make_error_code(error::incomplete_request);
+    }
+
+    ec = set_uri(std::string(cursor_start, cursor_end));
+    if (ec)
+    {
+        return ec;
+    }
+
+    return set_version(std::string(cursor_end + 1, end));
+}
+
+class CustomPpConfig : public websocketpp::config::asio
+{
 public:
     typedef CustomPpConfig type;
     typedef websocketpp::config::asio base;
 
-
-    static const size_t max_http_body_size = 100000000; //websocketpp::config::asio::max_http_body_size;
+    static const size_t max_http_body_size = MAX_READ_SIZE; // websocketpp::config::asio::max_http_body_size;
     typedef pipedal_elog elog_type;
     typedef pipedal_alog alog_type;
 
+    typedef request_with_file_upload request_type;
 
-    struct transport_config : public base::transport_config {
+    struct transport_config : public base::transport_config
+    {
         typedef type::concurrency_type concurrency_type;
         typedef type::alog_type alog_type;
         typedef type::elog_type elog_type;
@@ -62,11 +518,8 @@ public:
 
     typedef websocketpp::transport::asio::endpoint<transport_config>
         transport_type;
-
 };
 
-
-
 std::string
 pipedal::last_modified(const std::filesystem::path &path)
 {
@@ -86,7 +539,7 @@ pipedal::last_modified(const std::filesystem::path &path)
 static std::string getHostName()
 {
     char buff[512];
-    if (gethostname(buff,sizeof(buff)) == 0)
+    if (gethostname(buff, sizeof(buff)) == 0)
     {
         buff[511] = '\0';
         return buff;
@@ -98,7 +551,7 @@ static std::string getIpv4Address(const std::string interface)
 {
     int fd = -1;
     struct ifreq ifr;
-    memset(&ifr,0,sizeof(ifr));
+    memset(&ifr, 0, sizeof(ifr));
 
     fd = socket(AF_INET, SOCK_DGRAM, 0);
 
@@ -106,15 +559,16 @@ static std::string getIpv4Address(const std::string interface)
     ifr.ifr_addr.sa_family = AF_INET;
 
     /* I want an IP address attached to "eth0" */
-    strncpy(ifr.ifr_name, interface.c_str(), IFNAMSIZ-1);
+    strncpy(ifr.ifr_name, interface.c_str(), IFNAMSIZ - 1);
 
     int result = ioctl(fd, SIOCGIFADDR, &ifr);
-    if (result == -1) return "";
-
+    if (result == -1)
+        return "";
 
     close(fd);
     char *name = inet_ntoa(((struct sockaddr_in *)&ifr.ifr_addr)->sin_addr);
-    if (name == nullptr) return "";
+    if (name == nullptr)
+        return "";
     return name;
 }
 static std::map<std::string, std::string> extensionsToMimeType = {
@@ -187,15 +641,19 @@ namespace pipedal
         class HttpRequestImpl : public HttpRequest
         {
         private:
-            const server::connection_type::request_type &m_request;
+            server::connection_type::request_type &m_request;
 
         public:
             HttpRequestImpl(const server::connection_type::request_type &request)
-                : m_request(request)
+                : m_request(const_cast<server::connection_type::request_type &>(request)) // so we can get access to get_body_input_stream
             {
             }
 
             virtual const std::string &body() const { return m_request.get_body(); }
+            virtual std::istream &get_body_input_stream() { return m_request.get_body_input_stream(); }
+            virtual size_t content_length() const { return m_request.content_length(); }
+
+
             virtual const std::string &method() const { return m_request.get_method(); }
             virtual const std::string &get(const std::string &key) const { return m_request.get_header(key); }
             virtual bool keepAlive() const
@@ -241,8 +699,9 @@ namespace pipedal
 
         private:
             // IWriteCallback
-            virtual void close() { 
-                webSocket->close(websocketpp::close::status::normal, ""); 
+            virtual void close()
+            {
+                webSocket->close(websocketpp::close::status::normal, "");
                 webSocket = nullptr;
             }
 
@@ -279,7 +738,6 @@ namespace pipedal
 
                 Lv2Log::info(SS("WebSocketSession opened. (" << fromAddress << ")"));
 
-
                 auto pFactory = pServer->GetSocketFactory(requestUri);
                 if (!pFactory)
                 {
@@ -289,9 +747,9 @@ namespace pipedal
                 }
                 else
                 {
-                    using websocketpp::lib::bind;
-                    using websocketpp::lib::placeholders::_1;
-                    using websocketpp::lib::placeholders::_2;
+                    using std::bind;
+                    using std::placeholders::_1;
+                    using std::placeholders::_2;
 
                     webSocket->set_message_handler(bind(&WebSocketSession::on_message, this, _1, _2));
                     webSocket->set_close_handler(bind(&WebSocketSession::on_close, this, _1));
@@ -323,22 +781,23 @@ namespace pipedal
 
         void on_session_closed(WebSocketSession::ptr &session, connection_hdl hConnection)
         {
-            m_sessions.erase(session); 
+            m_sessions.erase(session);
             session = nullptr; // probably delete here.
             m_connections.erase(hConnection);
         }
 
         void NotFound(server::connection_type &connection, const std::string &filename)
         {
-            try {
+            try
+            {
                 // 404 error
                 std::stringstream ss;
 
                 ss << "<!doctype html><html><head>"
-                << "<title>Error 404 (Resource not found)</title><body>"
-                << "<h1>Error 404</h1>"
-                << "<p>The requested URL " << HtmlHelper::HtmlEncode(filename) << " was not found on this server.</p>"
-                << "</body></head></html>";
+                   << "<title>Error 404 (Resource not found)</title><body>"
+                   << "<h1>Error 404</h1>"
+                   << "<p>The requested URL " << HtmlHelper::HtmlEncode(filename) << " was not found on this server.</p>"
+                   << "</body></head></html>";
 
                 std::string body = ss.str();
                 connection.set_body(body);
@@ -346,23 +805,25 @@ namespace pipedal
                 ssLen << body.length();
                 connection.replace_header(HttpField::content_length, ssLen.str());
                 connection.set_status(websocketpp::http::status_code::not_found);
-            } catch (const std::exception&)
+            }
+            catch (const std::exception &)
             {
                 // ignored. Things weren't going well anyway.
-            } 
+            }
             return;
         };
         void ServerError(server::connection_type &connection, const std::string &error)
         {
-            try {
+            try
+            {
                 // 404 error
                 std::stringstream ss;
 
                 ss << "<!doctype html><html><head>"
-                << "<title>Error 500 (Server error)</title><body>"
-                << "<h1>Error 500</h1>"
-                << "<p>" << HtmlHelper::HtmlEncode(error) << "</p>"
-                << "</body></head></html>";
+                   << "<title>Error 500 (Server error)</title><body>"
+                   << "<h1>Error 500</h1>"
+                   << "<p>" << HtmlHelper::HtmlEncode(error) << "</p>"
+                   << "</body></head></html>";
                 std::string body = ss.str();
                 connection.set_body(body);
                 std::stringstream ssLen;
@@ -370,7 +831,8 @@ namespace pipedal
                 connection.replace_header(HttpField::content_length, ssLen.str());
 
                 connection.set_status(websocketpp::http::status_code::internal_server_error);
-            } catch (const std::exception&)
+            }
+            catch (const std::exception &)
             {
             }
             return;
@@ -457,17 +919,18 @@ namespace pipedal
             HttpResponseImpl res((*con));
 
             uri requestUri;
-            try {
-                requestUri.set(con->get_uri()->str().c_str());
-            } catch (const std::exception &e)
+            try
             {
-                ServerError(*con, SS("Unexpected error. " <<  e.what()));
+                requestUri.set(con->get_uri()->str().c_str());
+            }
+            catch (const std::exception &e)
+            {
+                ServerError(*con, SS("Unexpected error. " << e.what()));
                 return;
             }
 
             std::string fromAddress = SS(con->get_remote_endpoint());
 
-
             if (req.method() == HttpVerb::options)
             {
                 res.set(HttpField::access_control_allow_origin, origin);
@@ -486,14 +949,13 @@ namespace pipedal
                     try
                     {
 
-
                         if (req.method() == HttpVerb::head)
                         {
                             std::error_code ec;
                             res.set(HttpField::date, HtmlHelper::timeToHttpDate(time(nullptr)));
                             res.set(HttpField::access_control_allow_origin, origin);
 
-                            requestHandler->head_response(fromAddress,requestUri, req, res, ec);
+                            requestHandler->head_response(fromAddress, requestUri, req, res, ec);
                             res.keepAlive(req.keepAlive());
                             if (ec == std::errc::no_such_file_or_directory)
                             {
@@ -515,8 +977,7 @@ namespace pipedal
                             res.set(HttpField::date, HtmlHelper::timeToHttpDate(time(nullptr)));
                             res.set(HttpField::access_control_allow_origin, origin);
 
-
-                            requestHandler->get_response(fromAddress,requestUri, req, res, ec);
+                            requestHandler->get_response(fromAddress, requestUri, req, res, ec);
                             res.keepAlive(req.keepAlive());
 
                             if (ec == std::errc::no_such_file_or_directory)
@@ -540,7 +1001,7 @@ namespace pipedal
                             res.set(HttpField::date, HtmlHelper::timeToHttpDate(time(nullptr)));
                             res.set(HttpField::access_control_allow_origin, origin);
 
-                            requestHandler->post_response(fromAddress,requestUri, req, res, ec);
+                            requestHandler->post_response(fromAddress, requestUri, req, res, ec);
 
                             if (ec == std::errc::no_such_file_or_directory)
                             {
@@ -562,7 +1023,7 @@ namespace pipedal
                     }
                     catch (std::exception &e)
                     {
-                        ServerError(*con, SS("Unexpected error. " <<  e.what()));
+                        ServerError(*con, SS("Unexpected error. " << e.what()));
                         return;
                     }
                 }
@@ -628,13 +1089,14 @@ namespace pipedal
         {
             m_connections.insert(hdl);
 
-
-            try {
+            try
+            {
                 server::connection_ptr webSocket = m_endpoint.get_con_from_hdl(hdl);
                 WebSocketSession::ptr socketSession = std::make_shared<WebSocketSession>(this, webSocket);
                 socketSession->Open();
                 m_sessions.insert(socketSession);
-            } catch (const std::exception&e)
+            }
+            catch (const std::exception &e)
             {
                 Lv2Log::error("Failed to open session: %s", e.what());
             }
@@ -666,9 +1128,9 @@ namespace pipedal
                 m_endpoint.init_asio(&ioc);
 
                 // Bind the handlers we are using
-                using websocketpp::lib::bind;
-                using websocketpp::lib::placeholders::_1;
-                using websocketpp::lib::placeholders::_2;
+                using std::bind;
+                using std::placeholders::_1;
+                using std::placeholders::_2;
 
                 m_endpoint.set_open_handler(bind(&WebServerImpl::on_open, this, _1));
                 m_endpoint.set_close_handler(bind(&WebServerImpl::on_close, this, _1));
@@ -695,7 +1157,7 @@ namespace pipedal
                 std::stringstream ss;
                 ss << port;
                 // m_endpoint.listen(this->address, ss.str());
-                m_endpoint.listen(tcp::v6(),(uint16_t)port);
+                m_endpoint.listen(tcp::v6(), (uint16_t)port);
                 m_endpoint.start_accept();
 
                 // Start IOC service threads.
@@ -703,7 +1165,7 @@ namespace pipedal
                 v.reserve(threads - 1);
                 for (auto i = threads - 1; i > 0; --i)
                     v.emplace_back(
-                        [&ioc,i]
+                        [&ioc, i]
                         {
                             SetThreadName(SS("web_" << i));
                             ioc.run();

src/WebServer.hpp

@@ -26,7 +26,9 @@ namespace pipedal {
 
 class  HttpRequest {
 public:
-    virtual const std::string&body() const = 0;
+    //virtual const std::string&body() const = 0;
+    virtual std::istream &get_body_input_stream() = 0;
+    virtual size_t content_length() const = 0;
     virtual const std::string &method() const = 0;
     virtual const std::string&get(const std::string&key) const = 0;
     virtual bool keepAlive() const = 0;
@@ -161,14 +163,14 @@ public:
 
     virtual void head_response(
         const uri&request_uri,
-        const HttpRequest &req,
+        HttpRequest &req,
         HttpResponse &res,
         std::error_code &ec) = 0;
 
     virtual void head_response(
         const std::string&fromAddress,
         const uri&request_uri,
-        const HttpRequest &req,
+        HttpRequest &req,
         HttpResponse &res,
         std::error_code &ec) {
         head_response(request_uri,req,res,ec);
@@ -178,14 +180,14 @@ public:
 
     virtual void get_response(
         const uri&request_uri,
-        const HttpRequest &req,
+        HttpRequest &req,
         HttpResponse &res,
         std::error_code &ec) = 0;
 
     virtual void get_response(
         const std::string&fromAddress,
         const uri&request_uri,
-        const HttpRequest &req,
+        HttpRequest &req,
         HttpResponse &res,
         std::error_code &ec)
         {
@@ -195,7 +197,7 @@ public:
 
     virtual void post_response(
         const uri&request_uri,
-        const HttpRequest &req,
+        HttpRequest &req,
         HttpResponse &res,
         std::error_code &ec) 
     {
@@ -204,7 +206,7 @@ public:
     virtual void post_response(
         const std::string&fromAddress,
         const uri&request_uri,
-        const HttpRequest &req,
+        HttpRequest &req,
         HttpResponse &res,
         std::error_code &ec) 
     {

src/main.cpp

@@ -205,9 +205,9 @@ public:
 
     virtual void head_response(
         const uri &request_uri,
-        const HttpRequest &req,
+        HttpRequest &req,
         HttpResponse &res,
-        std::error_code &ec)
+        std::error_code &ec) override
     {
         try
         {
@@ -264,9 +264,9 @@ public:
 
     virtual void get_response(
         const uri &request_uri,
-        const HttpRequest &req,
+        HttpRequest &req,
         HttpResponse &res,
-        std::error_code &ec)
+        std::error_code &ec) override
     {
         try
         {
@@ -326,9 +326,9 @@ public:
     }
     virtual void post_response(
         const uri &request_uri,
-        const HttpRequest &req,
+        HttpRequest &req,
         HttpResponse &res,
-        std::error_code &ec)
+        std::error_code &ec) override
     {
         try
         {
@@ -336,9 +336,7 @@ public:
 
             if (segment == "uploadPluginPresets")
             {
-                const std::string &presetBody = req.body();
-                std::stringstream s(presetBody);
-                json_reader reader(s);
+                json_reader reader(req.get_body_input_stream());
                 PluginPresets presets;
                 reader.read(&presets);
                 model->UploadPluginPresets(presets);
@@ -354,9 +352,7 @@ public:
             }
             else if (segment == "uploadPreset")
             {
-                const std::string &presetBody = req.body();
-                std::stringstream s(presetBody);
-                json_reader reader(s);
+                json_reader reader(req.get_body_input_stream());
 
                 uint64_t uploadAfter = -1;
                 std::string strUploadAfter = request_uri.query("uploadAfter");
@@ -381,9 +377,7 @@ public:
             }
             else if (segment == "uploadBank")
             {
-                const std::string &presetBody = req.body();
-                std::istringstream s(presetBody);
-                json_reader reader(s);
+                json_reader reader(req.get_body_input_stream());
 
                 uint64_t uploadAfter = -1;
                 std::string strUploadAfter = request_uri.query("uploadAfter");
@@ -410,7 +404,6 @@ public:
                 res.set(HttpField::content_type, "application/json");
                 res.set(HttpField::cache_control, "no-cache");
 
-                const std::string &fileBody = req.body();
                 const std::string &directory = request_uri.query("directory");
                 const std::string &filename = request_uri.query("filename");
                 const std::string &patchProperty = request_uri.query("property");
@@ -427,7 +420,7 @@ public:
 
                 std::string outputFileName = std::filesystem::path(directory) / filename;
 
-                std::string path = this->model->UploadUserFile(directory,patchProperty,filename,fileBody);
+                std::string path = this->model->UploadUserFile(directory,patchProperty,filename,req.get_body_input_stream(), req.content_length());
 
                 std::stringstream ss;
                 json_writer writer(ss);
@@ -494,9 +487,9 @@ public:
 
     virtual void head_response(
         const uri &request_uri,
-        const HttpRequest &req,
+        HttpRequest &req,
         HttpResponse &res,
-        std::error_code &ec)
+        std::error_code &ec) override
     {
         // intercepted. See the other overload.
     }
@@ -504,9 +497,9 @@ public:
     virtual void head_response(
         const std::string &fromAddress,
         const uri &request_uri,
-        const HttpRequest &req,
+        HttpRequest &req,
         HttpResponse &res,
-        std::error_code &ec)
+        std::error_code &ec) override
     {
         std::string response = GetConfig(fromAddress);
         res.set(HttpField::content_type, "application/json");
@@ -517,9 +510,9 @@ public:
 
     virtual void get_response(
         const uri &request_uri,
-        const HttpRequest &req,
+        HttpRequest &req,
         HttpResponse &res,
-        std::error_code &ec)
+        std::error_code &ec) override
     {
         // intercepted. see the other overload.
     }
@@ -527,9 +520,9 @@ public:
     virtual void get_response(
         const std::string &fromAddress,
         const uri &request_uri,
-        const HttpRequest &req,
+        HttpRequest &req,
         HttpResponse &res,
-        std::error_code &ec)
+        std::error_code &ec) override
     {
         std::string response = GetConfig(fromAddress);
         res.set(HttpField::content_type, "application/json");