From e35c691b219c144da5854e92ec55ba46ec888f7f Mon Sep 17 00:00:00 2001 From: Robin Davies Date: Wed, 9 Oct 2024 13:34:03 -0400 Subject: [PATCH] v1.3.54 versioning. --- CMakeLists.txt | 4 ++-- README.md | 4 ++-- docs/Installing.md | 6 +++--- docs/ReleaseNotes.md | 34 ++++++++++++++++++++++++++++++++++ docs/download.md | 4 ++-- docs/index.md | 4 ++-- src/WebServer.cpp | 15 ++++++--------- todo.txt | 18 +++--------------- 8 files changed, 54 insertions(+), 35 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index f33874e..564358c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,10 +1,10 @@ cmake_minimum_required(VERSION 3.16.0) project(pipedal - VERSION 1.3.53 + VERSION 1.3.54 DESCRIPTION "PiPedal Guitar Effect Pedal For Raspberry Pi" HOMEPAGE_URL "https://rerdavies.github.io/pipedal" ) -set (DISPLAY_VERSION "PiPedal v1.3.53-Release") +set (DISPLAY_VERSION "PiPedal v1.3.54-Release") set (PACKAGE_ARCHITECTURE "arm64") set (CMAKE_INSTALL_PREFIX "/usr/") diff --git a/README.md b/README.md index 50d728b..a476f6b 100644 --- a/README.md +++ b/README.md @@ -6,13 +6,13 @@ -Download: v1.3.53 +Download: v1.3.54 Website: [https://rerdavies.github.io/pipedal](https://rerdavies.github.io/pipedal). Documentation: [https://rerdavies.github.io/pipedal/Documentation.html](https://rerdavies.github.io/pipedal/Documentation.html).   -#### NEW version 1.3.53 Release, providing [snapshots](https://rerdavies.github.io/pipedal/Snaphots.html), and a new Performance View. See the [release notes](https://rerdavies.github.io/pipedal/ReleaseNotes) for details. +#### NEW version 1.3.54 Release, providing [snapshots](https://rerdavies.github.io/pipedal/Snaphots.html), and a new Performance View. See the [release notes](https://rerdavies.github.io/pipedal/ReleaseNotes) for details.   diff --git a/docs/Installing.md b/docs/Installing.md index 248bf6c..083e737 100644 --- a/docs/Installing.md +++ b/docs/Installing.md @@ -13,17 +13,17 @@ page_icon: img/Install4.jpg Download the most recent Debian (.deb) package for your platform: -- [Raspberry Pi OS bookworm (64-bit) v1.3.53](https://github.com/rerdavies/pipedal/releases/download/) +- [Raspberry Pi OS bookworm (64-bit) v1.3.54](https://github.com/rerdavies/pipedal/releases/download/) - [Ubuntu/Raspberry Pi OS bullseyeye (64-bit) v1.2.31](https://github.com/rerdavies/pipedal/releases/download/v1.1.31/pipedal_1.1.31_arm64.deb) -Version 1.3.53 has not yet been tested on Ubuntu or Raspberry Pi OS bullseye. On these platforms, we recommend that you use version 1.1.31. +Version 1.3.54 has not yet been tested on Ubuntu or Raspberry Pi OS bullseye. On these platforms, we recommend that you use version 1.1.31. Install the package by running ``` sudo apt update cd ~/Downloads - sudo apt-get install pipedal_1.3.53_arm64.deb + sudo apt-get install pipedal_1.3.54_arm64.deb ``` Adjust accordingly if you have downloaded v1.1.31. diff --git a/docs/ReleaseNotes.md b/docs/ReleaseNotes.md index dc4e4cf..a9a898b 100644 --- a/docs/ReleaseNotes.md +++ b/docs/ReleaseNotes.md @@ -1,4 +1,38 @@ # Release Notes +## PiPedal 1.3.54 Release + +Improvements to and fixes for hotspot functionality. Fixes for problems with snapshots. + +Minor features; +- Enter key supported in most dialogs. + +Bug fixes. +- Various crashes related to snapshots. + +- Applying changes to wi-fi hostpot configuration would not change the configuration until PiPedal was rebooted (a regression). + The configuration of the Wi-Fi hotspot now changes as soon as you apply it. + +- The state of bypass switches was not getting captured in snapshots. + +- Crashes when scrolling through presets rapidly in the Snapshot view. + +- Web server redirects link-local IPv6 connections to non-link local address. (Improves client connectivity). + +- Force DHCP routing on hotspot connections. (Improves android client cnnectivity) + +- Missing MIDI device causes audio to stop. + +- The file model for snapshots was confusing and didn't entirely work as expected. Changes to snapshots now + only get saved when the preset to which they belong gets saved (explicit-save file model, instead of + Android file model). + +- Layout improvement to a number of dialogs when displayed on wide screens. + + + +Bug fixes: + + ## PiPedal 1.3.53 Release Major features: diff --git a/docs/download.md b/docs/download.md index 681c170..b1ebd8b 100644 --- a/docs/download.md +++ b/docs/download.md @@ -4,7 +4,7 @@ Download the most recent Debian (.deb) package for your platform: -- Raspberry Pi OS Bookworm (64-bit) v1.3.53 +- Raspberry Pi OS Bookworm (64-bit) v1.3.54 Install the package by running @@ -12,7 +12,7 @@ Install the package by running ``` sudo apt update cd ~/Downloads - sudo apt-get install ./pipedal_1.3.53_arm64.deb + sudo apt-get install ./pipedal_1.3.54_arm64.deb ``` Follow the instructions in [_Configuring PiPedal After Installation_](https://rerdavies.github.io/pipedal/Configuring.html) to complete the installation. diff --git a/docs/index.md b/docs/index.md index 66099d0..5e19088 100644 --- a/docs/index.md +++ b/docs/index.md @@ -1,7 +1,7 @@ -v1.3.53 +v1.3.54   @@ -9,7 +9,7 @@ To download PiPedal, click [here](download.md). To view PiPedal documentation, click [here](Documentation.md). -#### NEW version 1.3.53 Release. See the [release notes](https://rerdavies.github.io/pipedal/ReleaseNotes) for details. +#### NEW version 1.3.54 Release. See the [release notes](https://rerdavies.github.io/pipedal/ReleaseNotes) for details.   diff --git a/src/WebServer.cpp b/src/WebServer.cpp index c623922..5563a4e 100644 --- a/src/WebServer.cpp +++ b/src/WebServer.cpp @@ -993,19 +993,16 @@ namespace pipedal std::string addrOnly,portStr; splitAddressAndPort(fromAddress,addrOnly,portStr); - if (IsLinkLocalAddress(addrOnly)) + std::string nonLinkLocalUrl; + + if (RemapLinkLocalUrl(con->get_socket().remote_endpoint().address(), con->get_uri()->str(),&nonLinkLocalUrl)) { try { - uri_builder builder(requestUri); - - std::string redirectAddress = GetNonLinkLocalAddress(addrOnly); - builder.set_authority(redirectAddress+portStr); - std::string redirectUri = builder.str(); - - res.set(HttpField::location,redirectUri.c_str()); - Lv2Log::info(SS("Redirecting from " << fromAddress << " to " << redirectUri)); + Lv2Log::info(SS("Redirecting " << fromAddress << " to " << nonLinkLocalUrl)); res.keepAlive(false); + res.set(HttpField::location,nonLinkLocalUrl.c_str()); con->set_status(websocketpp::http::status_code::temporary_redirect); + res.setBody(""); return; } catch (const std::exception&e) { diff --git a/todo.txt b/todo.txt index 3d2380a..8dc7b59 100644 --- a/todo.txt +++ b/todo.txt @@ -1,20 +1,8 @@ -Splittype changes. -- disable splittype control when editing snapshot. -- identical structure requires no changes in split type. +Main menu on Pixel 5 client. +x1 bank menu (landscape pixel 5) should show current bank. +Restart discover on network change? -Review current handleNotifyPatchProperty. I tink server-side support needs to be -removed, and rely on handleNotifyPathPatchPropertyChanged instead. - -`private handleNotifyPatchProperty(clientHandle: number, instanceId: number, propertyUri: string, jsonObject: any) { - -Midi bindings. - - - revamp shutdown procedure for the audio thread. - write a marker on exit, and don't release - audioHost UNTIL the service thread has read the close marker. - -verify clean removal of dhcpcd and nm_p2p2d