shawn/op-pedal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update JackServerSettingsDialog.tsx

Browse Source 
Persistence change so that we can actually go on with OK
This commit is contained in:
Extremesecrecy
2025-07-27 13:51:42 -07:00
parent 70ba1b7fe1
commit d46f77bb61
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
vite/src/pipedal/JackServerSettingsDialog.tsx
+6 -4
View File
@@ -529,11 +529,11 @@ const JackServerSettingsDialog = withStyles(
super.componentWillUnmount(); super.componentWillUnmount();
this.mounted = false; this.mounted = false;
this.stopStatusTimer(); this.stopStatusTimer();
// Removed the saveSettings call from here.
// Persistence should only happen on explicit OK/PROCEED.
if (this.originalJackServerSettings) { if (this.originalJackServerSettings) {
// Revert any unapplied changes when the dialog is unmounted // Revert any unapplied changes when the dialog is unmounted
this.applySettings(this.originalJackServerSettings); this.applySettings(this.originalJackServerSettings);
// Persist the original settings so future dialogs show them
this.saveSettings(this.originalJackServerSettings);
this.originalJackServerSettings = undefined; this.originalJackServerSettings = undefined;
} }
} }
@@ -696,7 +696,9 @@ const JackServerSettingsDialog = withStyles(
if (this.originalJackServerSettings) { if (this.originalJackServerSettings) {
// Revert any applied settings // Revert any applied settings
this.applySettings(this.originalJackServerSettings); this.applySettings(this.originalJackServerSettings);
this.saveSettings(this.originalJackServerSettings); // IMPORTANT: Removed the saveSettings call here.
// If the user cancels, we only want to revert the active settings,
// not overwrite the permanently saved settings with the old ones.
this.originalJackServerSettings = undefined; this.originalJackServerSettings = undefined;
} }
} }
@@ -881,4 +883,4 @@ const JackServerSettingsDialog = withStyles(
}, },
styles); styles);
export default JackServerSettingsDialog; export default JackServerSettingsDialog;