Github build warnings

This commit is contained in:
Robin Davies
2024-08-20 21:02:28 -04:00
parent a438c0ae33
commit bfefb338e5
4 changed files with 9 additions and 5 deletions
+2 -1
View File
@@ -18,6 +18,7 @@
// CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. // CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
#include <iostream> #include <iostream>
#include <utility>
#include <stdlib.h> #include <stdlib.h>
#include <unistd.h> #include <unistd.h>
#include "CommandLineParser.hpp" #include "CommandLineParser.hpp"
@@ -603,7 +604,7 @@ void SetVarPermissions(
using namespace std::filesystem; using namespace std::filesystem;
try { try {
if (fs::exists(path)) { if (fs::exists(path)) {
chown(path.c_str(),uid,gid); std::ignore = chown(path.c_str(),uid,gid);
if (fs::is_directory(path)) { if (fs::is_directory(path)) {
fs::permissions(path, directoryPermissions, fs::perm_options::replace); fs::permissions(path, directoryPermissions, fs::perm_options::replace);
for (const auto& entry : fs::recursive_directory_iterator(path)) { for (const auto& entry : fs::recursive_directory_iterator(path)) {
+2 -1
View File
@@ -22,6 +22,7 @@
#include <sstream> #include <sstream>
#include <cstdint> #include <cstdint>
#include <string> #include <string>
#include <utility>
#include "json.hpp" #include "json.hpp"
#include "json_variant.hpp" #include "json_variant.hpp"
@@ -46,7 +47,7 @@ TEST_CASE("inverting_mutext test", "[inverting_mutex_test]")
std::thread thread( std::thread thread(
[&mutex]() mutable [&mutex]() mutable
{ {
nice(5); std::ignore = nice(5);
{ {
std::lock_guard<inverting_mutex> lock(mutex); std::lock_guard<inverting_mutex> lock(mutex);
SetThreadName("imTest"); SetThreadName("imTest");
+2 -1
View File
@@ -19,6 +19,7 @@
#include "MimeTypes.hpp" #include "MimeTypes.hpp"
#include "ss.hpp"
using namespace pipedal; using namespace pipedal;
@@ -136,7 +137,7 @@ static std::string toLower(const std::string&value)
void MimeTypes::AddMimeType(const std::string&extension_, const std::string&mimeType) void MimeTypes::AddMimeType(const std::string&extension_, const std::string&mimeType)
{ {
std::string extension = std::string(".") + toLower(extension_); std::string extension = SS("." << toLower(extension_));
mimeTypeToExtension[mimeType] = extension; mimeTypeToExtension[mimeType] = extension;
extensionToMimeType[extension] = mimeType; extensionToMimeType[extension] = mimeType;
if (mimeType.starts_with("audio/")) if (mimeType.starts_with("audio/"))
+3 -2
View File
@@ -39,7 +39,8 @@
#include <lv2/lv2plug.in/ns/ext/worker/worker.h> #include <lv2/lv2plug.in/ns/ext/worker/worker.h>
#include "Lv2Log.hpp" #include "Lv2Log.hpp"
#include <iostream> #include <iostream>
#include <unistd.h> // for nice() #include <unistd.h> // for nice(
#include <utility>
#include "util.hpp" #include "util.hpp"
using namespace pipedal; using namespace pipedal;
@@ -190,7 +191,7 @@ void HostWorkerThread::ThreadProc() noexcept
// run nice +2 (priority -2 on Windows) // run nice +2 (priority -2 on Windows)
SetThreadName("lv2_worker"); SetThreadName("lv2_worker");
errno = 0; errno = 0;
(void)nice(2); std::ignore = nice(2);
if (errno != 0) if (errno != 0)
{ {
std::cout << "Warning: Unable to run Lv2 schedule thread at nice +1" << std::endl; std::cout << "Warning: Unable to run Lv2 schedule thread at nice +1" << std::endl;