Clean up ToobAmp log messages and rdf:comment's.
This commit is contained in:
Binary file not shown.
@@ -0,0 +1,41 @@
|
||||
|
||||
import React, { ReactElement } from 'react';
|
||||
import Tooltip from "@mui/material/Tooltip"
|
||||
import { UiControl } from './Lv2Plugin';
|
||||
import Typography from "@mui/material/Typography";
|
||||
import Divider from '@mui/material/Divider';
|
||||
|
||||
|
||||
interface ControlTooltipProps {
|
||||
children: ReactElement,
|
||||
uiControl: UiControl
|
||||
}
|
||||
|
||||
|
||||
export default function ControlTooltip(props: ControlTooltipProps) {
|
||||
let { children, uiControl } = props;
|
||||
if (uiControl.comment && (uiControl.comment !== uiControl.name)) {
|
||||
return (
|
||||
<Tooltip title={(
|
||||
<React.Fragment>
|
||||
<Typography variant="caption">{uiControl.name}</Typography>
|
||||
<Divider />
|
||||
<Typography variant="caption">{uiControl.comment}</Typography>
|
||||
|
||||
</React.Fragment>
|
||||
)}
|
||||
placement="top-start" arrow enterDelay={1500} enterNextDelay={1500}
|
||||
>
|
||||
{children}
|
||||
</Tooltip>
|
||||
);
|
||||
} else {
|
||||
return (
|
||||
<Tooltip title={uiControl.name}
|
||||
placement="top-start" arrow enterDelay={1500} enterNextDelay={1500}
|
||||
>
|
||||
{children}
|
||||
</Tooltip>
|
||||
);
|
||||
}
|
||||
}
|
||||
@@ -34,6 +34,7 @@ import ButtonBase from '@mui/material/ButtonBase'
|
||||
import MoreHorizIcon from '@mui/icons-material/MoreHoriz';
|
||||
import {PedalboardItem} from './Pedalboard';
|
||||
import {isDarkMode} from './DarkMode';
|
||||
import Tooltip from "@mui/material/Tooltip"
|
||||
|
||||
export const StandardItemSize = { width: 80, height: 140 }
|
||||
|
||||
@@ -208,10 +209,14 @@ const FilePropertyControl =
|
||||
<div style={{ display: "flex", flexDirection: "column", alignItems: "center", justifyContent: "flex-start", width: item_width, margin: 8, paddingLeft: 8 }}>
|
||||
{/* TITLE SECTION */}
|
||||
<div style={{ flex: "0 0 auto", width: "100%", marginBottom: 8, marginLeft: 0, marginRight: 0 }}>
|
||||
<Tooltip title={fileProperty.label} placement="top-start" arrow
|
||||
enterDelay={1000} enterNextDelay={1000}
|
||||
>
|
||||
<Typography variant="caption" display="block" noWrap style={{
|
||||
width: "100%",
|
||||
textAlign: "start"
|
||||
}}> {fileProperty.label}</Typography>
|
||||
</Tooltip>
|
||||
</div>
|
||||
{/* CONTROL SECTION */}
|
||||
|
||||
|
||||
+10
-7
@@ -288,7 +288,10 @@ export const MainPage =
|
||||
this.setSelection(selectedId);
|
||||
let item = this.getPedalboardItem(selectedId);
|
||||
if (item != null) {
|
||||
if (item.isSplit()) {
|
||||
if (item.isStart() || item.isEnd())
|
||||
{
|
||||
// do nothing.
|
||||
} else if (item.isSplit()) {
|
||||
let split = item as PedalboardSplitItem;
|
||||
if (split.getSplitType() === SplitType.Ab) {
|
||||
let cv = split.getToggleAbControlValue();
|
||||
@@ -363,7 +366,7 @@ export const MainPage =
|
||||
titleBar(pedalboardItem: PedalboardItem | null): React.ReactNode {
|
||||
let title = "";
|
||||
let author = "";
|
||||
let pluginUri = "";
|
||||
let infoPluginUri = "";
|
||||
let presetsUri = "";
|
||||
let missing = false;
|
||||
if (pedalboardItem) {
|
||||
@@ -375,7 +378,7 @@ export const MainPage =
|
||||
title = pedalboardItem.pluginName ?? "#error";
|
||||
author = "";
|
||||
presetsUri = "";
|
||||
pluginUri = "";
|
||||
infoPluginUri = "";
|
||||
}
|
||||
else {
|
||||
let uiPlugin = this.model.getUiPlugin(pedalboardItem.uri);
|
||||
@@ -386,9 +389,9 @@ export const MainPage =
|
||||
title = uiPlugin.name;
|
||||
author = uiPlugin.author_name;
|
||||
presetsUri = uiPlugin.uri;
|
||||
if (uiPlugin.description.length > 20) {
|
||||
pluginUri = uiPlugin.uri;
|
||||
}
|
||||
// if (uiPlugin.description.length > 20) {
|
||||
// }
|
||||
infoPluginUri = uiPlugin.uri;
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -422,7 +425,7 @@ export const MainPage =
|
||||
)}
|
||||
</div>
|
||||
<div style={{ flex: "0 0 auto", verticalAlign: "center" }}>
|
||||
<PluginInfoDialog plugin_uri={pluginUri} />
|
||||
<PluginInfoDialog plugin_uri={infoPluginUri} />
|
||||
</div>
|
||||
<div style={{ flex: "0 0 auto" }}>
|
||||
<PluginPresetSelector pluginUri={presetsUri} instanceId={pedalboardItem?.instanceId ?? 0}
|
||||
|
||||
+120
-60
@@ -38,6 +38,9 @@ import {
|
||||
Pedalboard, PedalboardItem, PedalboardSplitItem, SplitType
|
||||
} from './Pedalboard';
|
||||
|
||||
import { ReactComponent as MidiIcon } from "./svg/ic_midi.svg";
|
||||
|
||||
|
||||
const START_CONTROL = Pedalboard.START_CONTROL;
|
||||
const END_CONTROL = Pedalboard.END_CONTROL;
|
||||
|
||||
@@ -57,8 +60,12 @@ const FRAME_SIZE: number = 36;
|
||||
const STROKE_WIDTH = 3;
|
||||
const STEREO_STROKE_WIDTH = 6;
|
||||
|
||||
const SVG_STROKE_WIDTH = "3";
|
||||
const SVG_STEREO_STROKE_WIDTH = "6";
|
||||
|
||||
const I_SVG_STROKE_WIDTH = 3;
|
||||
const I_SVG_STEREO_STROKE_WIDTH = 6;
|
||||
|
||||
const SVG_STROKE_WIDTH = I_SVG_STROKE_WIDTH.toString();
|
||||
const SVG_STEREO_STROKE_WIDTH = I_SVG_STEREO_STROKE_WIDTH.toString();
|
||||
|
||||
|
||||
|
||||
@@ -66,9 +73,13 @@ const EMPTY_ICON_URL = "img/fx_empty.svg";
|
||||
const ERROR_ICON_URL = "img/fx_error.svg";
|
||||
const TERMINAL_ICON_URL = "img/fx_terminal.svg";
|
||||
|
||||
function CalculateConnection(numberOfInputs: number, numberOfOutputs: number)
|
||||
{
|
||||
|
||||
function CalculateConnection(numberOfInputs: number, numberOfOutputs: number) {
|
||||
if (numberOfInputs === 0) {
|
||||
return numberOfOutputs;
|
||||
}
|
||||
if (numberOfOutputs === 0) {
|
||||
return numberOfInputs;
|
||||
}
|
||||
let result = Math.min(numberOfInputs, numberOfOutputs);
|
||||
if (result > 2) result = 2;
|
||||
return result;
|
||||
@@ -125,11 +136,18 @@ const pedalboardStyles = (theme: Theme) => createStyles({
|
||||
alignItems: "center",
|
||||
justifyContent: "center",
|
||||
},
|
||||
midiConnectorDecoration: {
|
||||
position: "absolute",
|
||||
left: -20,
|
||||
top: -6,
|
||||
fill: theme.palette.text.secondary
|
||||
},
|
||||
iconFrame: {
|
||||
|
||||
display: "flex",
|
||||
alignItems: "center",
|
||||
justifyContent: "center",
|
||||
position: "relative",
|
||||
|
||||
background: theme.palette.background.default,
|
||||
marginLeft: (CELL_WIDTH - FRAME_SIZE) / 2,
|
||||
@@ -227,6 +245,8 @@ class PedalLayout {
|
||||
|
||||
numberOfInputs: number = 2;
|
||||
numberOfOutputs: number = 2;
|
||||
originalInputs: number = 2;
|
||||
originalOutputs: number = 2;
|
||||
|
||||
pedalItem?: PedalboardItem;
|
||||
|
||||
@@ -286,11 +306,17 @@ class PedalLayout {
|
||||
this.iconUrl = TERMINAL_ICON_URL;
|
||||
this.numberOfInputs = 0;
|
||||
this.numberOfOutputs = PiPedalModelFactory.getInstance().jackSettings.get().inputAudioPorts.length;
|
||||
if (this.numberOfOutputs === 0) {
|
||||
this.numberOfOutputs = 1;
|
||||
}
|
||||
|
||||
} else if (pedalItem.uri === END_PEDALBOARD_ITEM_URI) {
|
||||
this.pluginType = PluginType.UtilityPlugin;
|
||||
this.iconUrl = TERMINAL_ICON_URL;
|
||||
this.numberOfInputs = PiPedalModelFactory.getInstance().jackSettings.get().outputAudioPorts.length;
|
||||
if (this.numberOfInputs === 0) {
|
||||
this.numberOfInputs = 1;
|
||||
}
|
||||
this.numberOfOutputs = 0;
|
||||
}
|
||||
else {
|
||||
@@ -299,8 +325,8 @@ class PedalLayout {
|
||||
this.pluginType = uiPlugin.plugin_type;
|
||||
this.iconUrl = SelectIconUri(uiPlugin.plugin_type);
|
||||
this.name = uiPlugin.label;
|
||||
this.numberOfInputs = Math.max(uiPlugin.audio_inputs,2);
|
||||
this.numberOfOutputs = Math.max(uiPlugin.audio_outputs,2);
|
||||
this.numberOfInputs = Math.min(uiPlugin.audio_inputs, 2);
|
||||
this.numberOfOutputs = Math.min(uiPlugin.audio_outputs, 2);
|
||||
} else {
|
||||
// default to empty plugin.
|
||||
this.pluginType = PluginType.ErrorPlugin;
|
||||
@@ -310,6 +336,8 @@ class PedalLayout {
|
||||
this.numberOfOutputs = 2;
|
||||
}
|
||||
}
|
||||
this.originalInputs = this.numberOfInputs;
|
||||
this.originalOutputs = this.numberOfOutputs;
|
||||
}
|
||||
isEmpty(): boolean {
|
||||
return (!this.pedalItem) || this.pedalItem.isEmpty();
|
||||
@@ -362,8 +390,7 @@ class LayoutParams {
|
||||
|
||||
const PedalboardView =
|
||||
withStyles(pedalboardStyles, { withTheme: true })(
|
||||
class extends Component<PedalboardProps, PedalboardState>
|
||||
{
|
||||
class extends Component<PedalboardProps, PedalboardState> {
|
||||
model: PiPedalModel;
|
||||
|
||||
frameRef: React.RefObject<HTMLDivElement>;
|
||||
@@ -386,15 +413,13 @@ const PedalboardView =
|
||||
this.handleTouchStart = this.handleTouchStart.bind(this);
|
||||
}
|
||||
|
||||
handleTouchStart(e: any)
|
||||
{
|
||||
handleTouchStart(e: any) {
|
||||
// just has to exist to allow Draggable to receive
|
||||
// touchyMove. :-/
|
||||
}
|
||||
|
||||
onDragEnd(instanceId: number, clientX: number, clientY: number) {
|
||||
if (!this.props.enableStructureEditing)
|
||||
{
|
||||
if (!this.props.enableStructureEditing) {
|
||||
return;
|
||||
}
|
||||
if (!this.currentLayout) return;
|
||||
@@ -463,8 +488,7 @@ const PedalboardView =
|
||||
}
|
||||
}
|
||||
let lastBottom = item.bottomChildren[item.bottomChildren.length - 1];
|
||||
if (clientX >= lastBottom.bounds.right && clientX < item.bounds.right-CELL_WIDTH/2)
|
||||
{
|
||||
if (clientX >= lastBottom.bounds.right && clientX < item.bounds.right - CELL_WIDTH / 2) {
|
||||
if (lastBottom.pedalItem) {
|
||||
this.model.movePedalboardItemAfter(instanceId, lastBottom.pedalItem.instanceId);
|
||||
this.setSelection(instanceId);
|
||||
@@ -485,8 +509,7 @@ const PedalboardView =
|
||||
this.setSelection(instanceId);
|
||||
return;
|
||||
} else {
|
||||
if (item.pedalItem)
|
||||
{
|
||||
if (item.pedalItem) {
|
||||
let margin = (CELL_WIDTH - FRAME_SIZE) / 2;
|
||||
if (clientX < item.bounds.x + margin) {
|
||||
this.model.movePedalboardItemBefore(instanceId, item.pedalItem.instanceId);
|
||||
@@ -634,8 +657,7 @@ const PedalboardView =
|
||||
doLayout(layoutItems: PedalLayout[]): LayoutSize {
|
||||
const TWO_ROW_HEIGHT = 142 - 14;
|
||||
|
||||
if (layoutItems.length === 0)
|
||||
{
|
||||
if (layoutItems.length === 0) {
|
||||
// if the current pedalboard is empty, reserve display space anyway.
|
||||
return { width: 1, height: TWO_ROW_HEIGHT };
|
||||
}
|
||||
@@ -682,15 +704,13 @@ const PedalboardView =
|
||||
}
|
||||
|
||||
onItemLongClick(event: SyntheticEvent, instanceId?: number): void {
|
||||
if (!instanceId)
|
||||
{
|
||||
if (!instanceId) {
|
||||
return;
|
||||
}
|
||||
event.preventDefault();
|
||||
event.stopPropagation();
|
||||
|
||||
if (!this.props.enableStructureEditing)
|
||||
{
|
||||
if (!this.props.enableStructureEditing) {
|
||||
this.setSelection(instanceId);
|
||||
return;
|
||||
}
|
||||
@@ -702,6 +722,24 @@ const PedalboardView =
|
||||
|
||||
}
|
||||
|
||||
strokeConnector(output: ReactNode[],channels: number,enabled: Boolean,svgPath: string)
|
||||
{
|
||||
let color = enabled ? ENABLED_CONNECTOR_COLOR : DISABLED_CONNECTOR_COLOR;
|
||||
|
||||
if (channels === 2) {
|
||||
output.push((
|
||||
<path key={this.renderKey++} d={svgPath} stroke={color} strokeWidth={SVG_STEREO_STROKE_WIDTH} />
|
||||
));
|
||||
output.push((
|
||||
<path key={this.renderKey++} d={svgPath} stroke={this.bgColor} strokeWidth={SVG_STROKE_WIDTH} />
|
||||
));
|
||||
} else if (channels === 1) {
|
||||
output.push((
|
||||
<path key={this.renderKey++} d={svgPath} stroke={color} strokeWidth={SVG_STROKE_WIDTH} />
|
||||
));
|
||||
}
|
||||
}
|
||||
|
||||
renderConnector(output: ReactNode[], item: PedalLayout, enabled: boolean): void {
|
||||
// let classes = this.props.classes;
|
||||
let x_ = item.bounds.x + CELL_WIDTH / 2;
|
||||
@@ -709,8 +747,19 @@ const PedalboardView =
|
||||
let numberOfOutputs = item.numberOfOutputs;
|
||||
let color = enabled ? ENABLED_CONNECTOR_COLOR : DISABLED_CONNECTOR_COLOR;
|
||||
let stereoCenterColor = this.bgColor;
|
||||
|
||||
if (item.originalInputs === 0) {
|
||||
// break the input paths.
|
||||
let rx = item.bounds.x + CELL_WIDTH / 2 - FRAME_SIZE / 2 - 4;
|
||||
let ry = y_ - 4;
|
||||
|
||||
output.push((
|
||||
<rect key={this.renderKey++} x={rx} y={ry} width={4} height={8} fill={this.props.theme.palette.background.paper} />
|
||||
));
|
||||
}
|
||||
let svgPath = new SvgPathBuilder().moveTo(x_, y_).lineTo(x_ + CELL_WIDTH, y_).toString();
|
||||
|
||||
|
||||
if (numberOfOutputs === 2) {
|
||||
output.push((
|
||||
<path key={this.renderKey++} d={svgPath} stroke={color} strokeWidth={SVG_STEREO_STROKE_WIDTH} />
|
||||
@@ -722,6 +771,11 @@ const PedalboardView =
|
||||
output.push((
|
||||
<path key={this.renderKey++} d={svgPath} stroke={color} strokeWidth={SVG_STROKE_WIDTH} />
|
||||
));
|
||||
} else {
|
||||
output.push((
|
||||
<path key={this.renderKey++} d={svgPath} stroke={DISABLED_CONNECTOR_COLOR} strokeWidth={SVG_STROKE_WIDTH} />
|
||||
));
|
||||
|
||||
}
|
||||
}
|
||||
renderSplitConnectors(output: ReactNode[], item: PedalLayout, enabled: boolean, shortSplitOutput: boolean,): void {
|
||||
@@ -895,8 +949,7 @@ const PedalboardView =
|
||||
|
||||
}
|
||||
}
|
||||
if (thirdPath != null)
|
||||
{
|
||||
if (thirdPath != null) {
|
||||
// stereo output of L/R splitter
|
||||
output.push((
|
||||
<path key={this.renderKey++} d={thirdPath} stroke={secondPathColor} strokeWidth={SVG_STEREO_STROKE_WIDTH} />
|
||||
@@ -908,14 +961,11 @@ const PedalboardView =
|
||||
|
||||
}
|
||||
}
|
||||
getScrollContainer()
|
||||
{
|
||||
getScrollContainer() {
|
||||
let el: HTMLElement | undefined | null = this.scrollRef.current;
|
||||
// actually not here anymore. :-/ It has a reactive definition in MainPage.tsx now.
|
||||
while (el)
|
||||
{
|
||||
if (el.id === "pedalboardScroll")
|
||||
{
|
||||
while (el) {
|
||||
if (el.id === "pedalboardScroll") {
|
||||
return el as HTMLDivElement;
|
||||
}
|
||||
el = el.parentElement;
|
||||
@@ -929,11 +979,19 @@ const PedalboardView =
|
||||
draggable: boolean,
|
||||
enabled: boolean,
|
||||
hasBorder: boolean = true,
|
||||
pluginNotFound: boolean)
|
||||
pluginNotFound: boolean,
|
||||
hasMidiConnector: boolean
|
||||
)
|
||||
: ReactNode {
|
||||
let classes = this.props.classes;
|
||||
return (
|
||||
<div className={hasBorder ? classes.iconFrame : classes.borderlessIconFrame} onContextMenu={(e) => { e.preventDefault(); }}>
|
||||
{hasMidiConnector && (
|
||||
<div className={classes.midiConnectorDecoration} >
|
||||
<MidiIcon style={{ width: 16, height: 16, fill: this.props.theme.palette.text.secondary }} />
|
||||
</div>
|
||||
|
||||
)}
|
||||
|
||||
<ButtonBase style={{ width: "100%", height: "100%" }}
|
||||
onClick={(e) => { this.onItemClick(e, instanceId); }}
|
||||
@@ -1008,7 +1066,7 @@ const PedalboardView =
|
||||
result.push(<div key={this.renderKey++} className={classes.splitItem} style={{ left: item.bounds.x, top: item.bounds.y, width: item.bounds.width }} >
|
||||
<div className={classes.splitStart} >
|
||||
|
||||
{this.pedalButton(START_CONTROL, item.pluginType,false,true,false,false)}
|
||||
{this.pedalButton(START_CONTROL, item.pluginType, false, true, false, false, false)}
|
||||
</div>
|
||||
</div>);
|
||||
break;
|
||||
@@ -1016,7 +1074,7 @@ const PedalboardView =
|
||||
result.push(<div key={this.renderKey++} className={classes.splitItem} style={{ left: item.bounds.x, top: item.bounds.y, width: item.bounds.width }} >
|
||||
<div className={classes.splitStart} >
|
||||
|
||||
{this.pedalButton(END_CONTROL, item.pluginType, false,true,false,false)}
|
||||
{this.pedalButton(END_CONTROL, item.pluginType, false, true, false, false, false)}
|
||||
</div>
|
||||
</div>);
|
||||
break;
|
||||
@@ -1025,7 +1083,7 @@ const PedalboardView =
|
||||
|
||||
result.push(<div key={this.renderKey++} className={classes.splitItem} style={{ left: item.bounds.x, top: item.bounds.y, width: item.bounds.width }} >
|
||||
<div className={classes.splitStart} >
|
||||
{this.pedalButton(item.pedalItem?.instanceId ?? -1, this.getSplitterIcon(item), false,true,true,false)}
|
||||
{this.pedalButton(item.pedalItem?.instanceId ?? -1, this.getSplitterIcon(item), false, true, true, false, false)}
|
||||
</div>
|
||||
</div>);
|
||||
|
||||
@@ -1042,8 +1100,16 @@ const PedalboardView =
|
||||
)
|
||||
let uiPlugin = this.model.getUiPlugin(item.pedalItem?.uri ?? "");
|
||||
let pluginMissing = uiPlugin == null;
|
||||
|
||||
result.push(<div key={this.renderKey++} className={classes.pedalItem} style={{ left: item.bounds.x, top: item.bounds.y }} >
|
||||
{this.pedalButton(item.pedalItem?.instanceId ?? -1, item.pluginType, !item.isEmpty(), item.pedalItem?.isEnabled ?? false,true,pluginMissing)}
|
||||
{this.pedalButton(
|
||||
item.pedalItem?.instanceId ?? -1,
|
||||
item.pluginType,
|
||||
!item.isEmpty(),
|
||||
item.pedalItem?.isEnabled ?? false,
|
||||
true,
|
||||
pluginMissing,
|
||||
uiPlugin ? ((uiPlugin.has_midi_input !== 0) || (uiPlugin.has_midi_output !== 0)) : false)}
|
||||
|
||||
</div>);
|
||||
|
||||
@@ -1090,13 +1156,10 @@ const PedalboardView =
|
||||
this.markStereoBackward(layoutChain, numberOfOutputs);
|
||||
}
|
||||
|
||||
markStereoBackward(layoutChain: PedalLayout[], numberOfOutputs: number) : number
|
||||
{
|
||||
for (let i = layoutChain.length-1; i >= 0; --i)
|
||||
{
|
||||
markStereoBackward(layoutChain: PedalLayout[], numberOfOutputs: number): number {
|
||||
for (let i = layoutChain.length - 1; i >= 0; --i) {
|
||||
let item = layoutChain[i];
|
||||
if (item.isSplitter())
|
||||
{
|
||||
if (item.isSplitter()) {
|
||||
item.numberOfOutputs = CalculateConnection(item.numberOfOutputs, numberOfOutputs)
|
||||
|
||||
this.markStereoBackward(item.topChildren, numberOfOutputs);
|
||||
@@ -1105,21 +1168,17 @@ const PedalboardView =
|
||||
let bottomInputs = item.bottomChildren[0].numberOfInputs;
|
||||
|
||||
let splitItem = item.pedalItem as PedalboardSplitItem;
|
||||
if (splitItem.getSplitType() !== SplitType.Lr)
|
||||
{
|
||||
if (splitItem.getSplitType() !== SplitType.Lr) {
|
||||
item.numberOfInputs = CalculateConnection(item.numberOfInputs, Math.max(topInputs, bottomInputs));
|
||||
}
|
||||
} else if (item.isEnd())
|
||||
{
|
||||
} else if (item.isEnd()) {
|
||||
|
||||
} else if (item.isStart())
|
||||
{
|
||||
} else if (item.isStart()) {
|
||||
item.numberOfOutputs = CalculateConnection(item.numberOfOutputs, numberOfOutputs);
|
||||
return item.numberOfOutputs;
|
||||
|
||||
} else if (item.isEmpty()) {
|
||||
if (numberOfOutputs === 0)
|
||||
{
|
||||
if (numberOfOutputs === 0) {
|
||||
item.numberOfOutputs = 0;
|
||||
item.numberOfInputs = CalculateConnection(item.numberOfInputs, 2);
|
||||
} else {
|
||||
@@ -1133,8 +1192,7 @@ const PedalboardView =
|
||||
}
|
||||
return numberOfOutputs;
|
||||
}
|
||||
markStereoForward(layoutChain: PedalLayout[],numberOfInputs: number): number
|
||||
{
|
||||
markStereoForward(layoutChain: PedalLayout[], numberOfInputs: number): number {
|
||||
if (layoutChain.length === 0) {
|
||||
return numberOfInputs;
|
||||
}
|
||||
@@ -1145,8 +1203,7 @@ const PedalboardView =
|
||||
item.numberOfInputs = numberOfInputs;
|
||||
|
||||
let chainInputs = numberOfInputs;
|
||||
if (splitter.getSplitType() === SplitType.Lr)
|
||||
{
|
||||
if (splitter.getSplitType() === SplitType.Lr) {
|
||||
chainInputs = CalculateConnection(numberOfInputs, 1);
|
||||
}
|
||||
let topOutputs = this.markStereoForward(item.topChildren, chainInputs);
|
||||
@@ -1162,8 +1219,7 @@ const PedalboardView =
|
||||
} else {
|
||||
item.numberOfOutputs = (topOutputs >= 1 || bottomOutputs >= 1) ? 2 : 1;
|
||||
}
|
||||
} else if (item.isStart())
|
||||
{
|
||||
} else if (item.isStart()) {
|
||||
item.numberOfOutputs = Math.min(PiPedalModelFactory.getInstance().jackSettings.get().inputAudioPorts.length, 2);
|
||||
} else if (item.isEnd()) {
|
||||
item.numberOfInputs =
|
||||
@@ -1173,16 +1229,21 @@ const PedalboardView =
|
||||
return item.numberOfInputs;
|
||||
} else if (item.isEmpty()) {
|
||||
item.numberOfInputs = numberOfInputs;
|
||||
if (numberOfInputs === 0)
|
||||
{
|
||||
if (numberOfInputs === 0) {
|
||||
item.numberOfOutputs = 2;
|
||||
} else {
|
||||
item.numberOfOutputs = item.numberOfInputs;
|
||||
}
|
||||
} else {
|
||||
if (item.numberOfInputs === 0) // zero-input plugins merge their output with the input.
|
||||
{
|
||||
item.numberOfInputs = numberOfInputs;
|
||||
item.numberOfOutputs = Math.max(item.numberOfOutputs, numberOfInputs);
|
||||
} else {
|
||||
item.numberOfInputs = CalculateConnection(numberOfInputs, this.getNumberOfInputs(item));
|
||||
item.numberOfOutputs = this.getNumberOfOutputs(item);
|
||||
}
|
||||
}
|
||||
numberOfInputs = item.numberOfOutputs;
|
||||
}
|
||||
return numberOfInputs;
|
||||
@@ -1196,8 +1257,7 @@ const PedalboardView =
|
||||
let layoutChain = makeChain(this.model, this.state.pedalboard?.items);
|
||||
let start = PedalLayout.Start();
|
||||
let end = PedalLayout.End();
|
||||
if (layoutChain.length !== 0)
|
||||
{
|
||||
if (layoutChain.length !== 0) {
|
||||
layoutChain.splice(0, 0, start);
|
||||
layoutChain.splice(layoutChain.length, 0, end);
|
||||
this.markStereoOutputs(layoutChain, 2, 2);
|
||||
|
||||
@@ -33,6 +33,7 @@ import MenuItem from '@mui/material/MenuItem';
|
||||
import { PiPedalModel, PiPedalModelFactory } from './PiPedalModel';
|
||||
import { ReactComponent as DialIcon } from './svg/fx_dial.svg';
|
||||
import { isDarkMode } from './DarkMode';
|
||||
import ControlTooltip from './ControlTooltip';
|
||||
|
||||
const MIN_ANGLE = -135;
|
||||
const MAX_ANGLE = 135;
|
||||
@@ -725,10 +726,12 @@ const PluginControl =
|
||||
<div ref={this.frameRef} style={{ display: "flex", flexDirection: "column", alignItems: "center", justifyContent: "flex-start", width: item_width, margin: 8 }}>
|
||||
{/* TITLE SECTION */}
|
||||
<div style={{ flex: "0 0 auto", alignSelf:"stretch", marginBottom: 8, marginLeft: isSelect ? 16 : 0, marginRight: 0 }}>
|
||||
<ControlTooltip uiControl={control} >
|
||||
<Typography variant="caption" display="block" noWrap style={{
|
||||
width: "100%",
|
||||
textAlign: isSelect ? "left" : "center"
|
||||
}}> {isTrigger ? "\u00A0" : control.name}</Typography>
|
||||
</ControlTooltip>
|
||||
</div>
|
||||
{/* CONTROL SECTION */}
|
||||
|
||||
|
||||
@@ -40,6 +40,7 @@ import JsonAtom from './JsonAtom';
|
||||
import PluginOutputControl from './PluginOutputControl';
|
||||
import Units from './Units';
|
||||
import ToobFrequencyResponseView from './ToobFrequencyResponseView';
|
||||
import Tooltip from '@mui/material/Tooltip';
|
||||
|
||||
|
||||
export const StandardItemSize = { width: 80, height: 110 };
|
||||
@@ -553,7 +554,11 @@ const PluginControlView =
|
||||
result.push((
|
||||
<div key={"ctl" + (this.controlKeyIndex++)} className={!isLandscapeGrid ? classes.portGroup : classes.portGroupLandscape}>
|
||||
<div className={classes.portGroupTitle}>
|
||||
<Tooltip title={controlGroup.name}
|
||||
placement="top-start" arrow enterDelay={1500} enterNextDelay={1500}
|
||||
>
|
||||
<Typography noWrap variant="caption" >{controlGroup.name}</Typography>
|
||||
</Tooltip>
|
||||
</div>
|
||||
<div className={classes.portGroupControls} >
|
||||
{
|
||||
|
||||
@@ -40,8 +40,7 @@ import { Remark } from 'react-remark';
|
||||
/* eslint-disable */
|
||||
let myTheme: Theme | undefined = undefined;
|
||||
|
||||
const styles = (theme: Theme) =>
|
||||
{
|
||||
const styles = (theme: Theme) => {
|
||||
myTheme = theme;
|
||||
return createStyles({
|
||||
root: {
|
||||
@@ -151,6 +150,7 @@ function makeControls(controls: UiControl[]) {
|
||||
break;
|
||||
}
|
||||
}
|
||||
hasComments = true;
|
||||
if (hasComments) {
|
||||
let trs: React.ReactElement[] = [];
|
||||
for (let i = 0; i < controls.length; ++i) {
|
||||
@@ -286,6 +286,8 @@ const PluginInfoDialog = withStyles(styles)((props: PluginInfoProps) => {
|
||||
{
|
||||
makeControls(plugin.controls)
|
||||
}
|
||||
{plugin.description.length > 0 && (
|
||||
<div>
|
||||
<Typography gutterBottom variant="body2" style={{ paddingTop: "1em" }}>
|
||||
Description:
|
||||
</Typography>
|
||||
@@ -317,6 +319,8 @@ const PluginInfoDialog = withStyles(styles)((props: PluginInfoProps) => {
|
||||
{plugin.description}
|
||||
</Remark>
|
||||
</div>
|
||||
</div>
|
||||
)}
|
||||
</PluginInfoDialogContent>
|
||||
<PluginInfoDialogActions>
|
||||
<Button variant="dialogPrimary" autoFocus onClick={handleClose} style={{ width: "130px" }}>
|
||||
|
||||
@@ -28,6 +28,7 @@ import { PiPedalModel, PiPedalModelFactory, MonitorPortHandle,State } from './Pi
|
||||
import { isDarkMode } from './DarkMode';
|
||||
import GxTunerControl from './GxTunerControl';
|
||||
import Units from './Units';
|
||||
import ControlTooltip from './ControlTooltip';
|
||||
|
||||
|
||||
|
||||
@@ -74,8 +75,7 @@ type PluginOutputControlState = {
|
||||
|
||||
const PluginOutputControl =
|
||||
withStyles(styles, { withTheme: true })(
|
||||
class extends Component<PluginOutputControlProps, PluginOutputControlState>
|
||||
{
|
||||
class extends Component<PluginOutputControlProps, PluginOutputControlState> {
|
||||
|
||||
private model: PiPedalModel;
|
||||
private vuRef: React.RefObject<HTMLDivElement>;
|
||||
@@ -98,10 +98,8 @@ const PluginOutputControl =
|
||||
this.onConnectionStateChanged = this.onConnectionStateChanged.bind(this);
|
||||
}
|
||||
|
||||
private onConnectionStateChanged(state: State)
|
||||
{
|
||||
if (state === State.Ready)
|
||||
{
|
||||
private onConnectionStateChanged(state: State) {
|
||||
if (state === State.Ready) {
|
||||
this.unsubscribe();
|
||||
this.subscribe();
|
||||
}
|
||||
@@ -127,8 +125,7 @@ const PluginOutputControl =
|
||||
}
|
||||
|
||||
componentDidUpdate(prevProps: Readonly<PluginOutputControlProps>, prevState: Readonly<PluginOutputControlState>, snapshot?: any): void {
|
||||
if (prevProps.instanceId !== this.props.instanceId)
|
||||
{
|
||||
if (prevProps.instanceId !== this.props.instanceId) {
|
||||
this.unsubscribe();
|
||||
this.subscribe();
|
||||
}
|
||||
@@ -144,8 +141,7 @@ const PluginOutputControl =
|
||||
private dbVuHoldTime = 0.0;
|
||||
|
||||
private requestDbVuAnimation() {
|
||||
if (!this.animationHandle)
|
||||
{
|
||||
if (!this.animationHandle) {
|
||||
this.animationHandle = requestAnimationFrame(
|
||||
() => {
|
||||
let value = this.dbVuValue;
|
||||
@@ -153,13 +149,11 @@ const PluginOutputControl =
|
||||
let top = range - this.VU_HEIGHT;
|
||||
if (top > 0) top = 0;
|
||||
|
||||
if (value > this.dbVuTelltale)
|
||||
{
|
||||
if (value > this.dbVuTelltale) {
|
||||
this.dbVuTelltale = value;
|
||||
this.dbVuHoldTime = Date.now() + 2000;
|
||||
}
|
||||
if (this.dbVuRef.current)
|
||||
{
|
||||
if (this.dbVuRef.current) {
|
||||
this.dbVuRef.current.style.marginTop = top + "px";
|
||||
}
|
||||
this.animationHandle = undefined;
|
||||
@@ -171,16 +165,13 @@ const PluginOutputControl =
|
||||
|
||||
updateDbVuTelltale() {
|
||||
let telltaleDone = true;
|
||||
if (this.dbVuHoldTime !== 0)
|
||||
{
|
||||
if (this.dbVuHoldTime !== 0) {
|
||||
telltaleDone = false;
|
||||
let t = Date.now();
|
||||
if (t >= this.dbVuHoldTime)
|
||||
{
|
||||
if (t >= this.dbVuHoldTime) {
|
||||
let dt = t - this.dbVuHoldTime;
|
||||
let telltaleValue = this.dbVuTelltale - 30 * dt / 1000;
|
||||
if (telltaleValue < -200)
|
||||
{
|
||||
if (telltaleValue < -200) {
|
||||
telltaleValue = -200;
|
||||
telltaleDone = true;
|
||||
}
|
||||
@@ -191,34 +182,28 @@ const PluginOutputControl =
|
||||
let y = this.dbVuMap(this.dbVuTelltale);
|
||||
if (y < 0) y = 0;
|
||||
|
||||
if (this.dbVuTelltaleRef.current)
|
||||
{
|
||||
if (this.dbVuTelltaleRef.current) {
|
||||
let telltaleStyle = this.dbVuTelltaleRef.current.style;
|
||||
telltaleStyle.marginTop = y + "px";
|
||||
let telltaleColor = "#0C0";
|
||||
if (this.dbVuTelltale >= 0)
|
||||
{
|
||||
if (this.dbVuTelltale >= 0) {
|
||||
telltaleColor = "#F00";
|
||||
} else if (this.dbVuTelltale >= -10)
|
||||
{
|
||||
} else if (this.dbVuTelltale >= -10) {
|
||||
telltaleColor = "#FF0";
|
||||
}
|
||||
telltaleStyle.background = telltaleColor;
|
||||
}
|
||||
}
|
||||
if (!telltaleDone)
|
||||
{
|
||||
if (!telltaleDone) {
|
||||
this.requestDbVuAnimation();
|
||||
}
|
||||
}
|
||||
private updateValue(value: number) {
|
||||
if (this.lampRef.current)
|
||||
{
|
||||
if (this.lampRef.current) {
|
||||
let control = this.props.uiControl;
|
||||
let range = (value - control.min_value) / (control.max_value - control.min_value);
|
||||
this.lampRef.current.style.opacity = range + "";
|
||||
} else if (this.dbVuRef.current)
|
||||
{
|
||||
} else if (this.dbVuRef.current) {
|
||||
this.dbVuValue = value;
|
||||
this.requestDbVuAnimation();
|
||||
}
|
||||
@@ -227,12 +212,10 @@ const PluginOutputControl =
|
||||
let range = (value - control.min_value) / (control.max_value - control.min_value);
|
||||
let top = this.VU_HEIGHT - range * this.VU_HEIGHT;
|
||||
|
||||
if (!this.animationHandle)
|
||||
{
|
||||
if (!this.animationHandle) {
|
||||
this.animationHandle = requestAnimationFrame(
|
||||
() => {
|
||||
if (this.vuRef.current)
|
||||
{
|
||||
if (this.vuRef.current) {
|
||||
this.vuRef.current.style.marginTop = top + "px";
|
||||
}
|
||||
this.animationHandle = undefined;
|
||||
@@ -317,8 +300,7 @@ const PluginOutputControl =
|
||||
item_width = 80;
|
||||
}
|
||||
}
|
||||
if (control.isTuner())
|
||||
{
|
||||
if (control.isTuner()) {
|
||||
item_width = undefined;
|
||||
return (
|
||||
<div style={{ display: "flex", flexDirection: "column", width: item_width, margin: 8, height: 98 }}>
|
||||
@@ -329,8 +311,7 @@ const PluginOutputControl =
|
||||
|
||||
);
|
||||
|
||||
} else if (control.isDbVu())
|
||||
{
|
||||
} else if (control.isDbVu()) {
|
||||
item_width = undefined;
|
||||
let redLevel = this.dbVuMap(0);
|
||||
let yellowLevel = this.dbVuMap(-10);
|
||||
@@ -338,10 +319,12 @@ const PluginOutputControl =
|
||||
<div style={{ display: "flex", flexDirection: "column", width: item_width, margin: 8, height: 98 }}>
|
||||
{/* TITLE SECTION */}
|
||||
<div style={{ flex: "0 0 auto", width: "100%", marginBottom: 8, marginLeft: 0, marginRight: 0 }}>
|
||||
<ControlTooltip uiControl={control}>
|
||||
<Typography variant="caption" display="block" style={{
|
||||
width: "100%",
|
||||
textAlign: "center"
|
||||
}}> {control.name === "" ? "\u00A0" : control.name}</Typography>
|
||||
</ControlTooltip>
|
||||
</div>
|
||||
{/* CONTROL SECTION */}
|
||||
|
||||
@@ -369,10 +352,12 @@ const PluginOutputControl =
|
||||
<div style={{ display: "flex", flexDirection: "column", width: item_width, margin: 8, height: 98 }}>
|
||||
{/* TITLE SECTION */}
|
||||
<div style={{ flex: "0 0 auto", width: "100%", marginBottom: 8, marginLeft: 0, marginRight: 0 }}>
|
||||
<ControlTooltip uiControl={control}>
|
||||
<Typography variant="caption" display="block" style={{
|
||||
width: "100%",
|
||||
textAlign: "center"
|
||||
}}> {control.name === "" ? "\u00A0" : control.name}</Typography>
|
||||
</ControlTooltip>
|
||||
</div>
|
||||
{/* CONTROL SECTION */}
|
||||
|
||||
@@ -396,24 +381,29 @@ const PluginOutputControl =
|
||||
item_width = undefined;
|
||||
let attachedLamp = control.name === "" || control.name === "\u00A0";
|
||||
return (
|
||||
<div style={{ display: "flex", flexDirection: "column", width: item_width,
|
||||
<div style={{
|
||||
display: "flex", flexDirection: "column", width: item_width,
|
||||
marginTop: 8, marginBottom: 8, marginRight: 8, marginLeft: (attachedLamp ? 0 : 8), height: 98
|
||||
}}>
|
||||
{/* TITLE SECTION */}
|
||||
<div style={{ flex: "0 0 auto", width: "100%", marginBottom: 8, marginLeft: 0, marginRight: 0 }}>
|
||||
<ControlTooltip uiControl={control}>
|
||||
<Typography variant="caption" display="block" style={{
|
||||
width: "100%",
|
||||
textAlign: "center"
|
||||
}}> {control.name === "" ? "\u00A0" : (control.name)}</Typography>
|
||||
</ControlTooltip>
|
||||
</div>
|
||||
{/* CONTROL SECTION */}
|
||||
|
||||
<div style={{ flex: "1 1 auto", display: "flex", justifyContent: "left", alignItems: "start", flexFlow: "row nowrap" }}>
|
||||
<div style={{ width: 12, height: 12, background: isDarkMode() ? "#111" : "#444", borderRadius: 5, position: "relative" }}>
|
||||
<div ref={this.lampRef} style={{ width: 8, height: 8,
|
||||
<div ref={this.lampRef} style={{
|
||||
width: 8, height: 8,
|
||||
background: (isDarkMode() ? "radial-gradient(circle at center, #F00 0, #F00 20%, #333 100%)"
|
||||
: "radial-gradient(circle at center, #F44 0, #F44 40%, #644 100%)"),
|
||||
opacity: 0, borderRadius: 3,margin: 2,position: "absolute" }} />
|
||||
opacity: 0, borderRadius: 3, margin: 2, position: "absolute"
|
||||
}} />
|
||||
</div>
|
||||
|
||||
</div>
|
||||
@@ -429,11 +419,14 @@ const PluginOutputControl =
|
||||
<div style={{ display: "flex", flexDirection: "column", width: item_width, margin: 8, height: 98 }}>
|
||||
{/* TITLE SECTION */}
|
||||
<div style={{ flex: "0 0 auto", width: "100%", marginBottom: 8, marginLeft: 0, marginRight: 0 }}>
|
||||
<ControlTooltip uiControl={control}>
|
||||
<Typography variant="caption" display="block" style={{
|
||||
width: "100%",
|
||||
textAlign: "left"
|
||||
}}> {control.name}</Typography>
|
||||
</ControlTooltip>
|
||||
</div>
|
||||
|
||||
{/* CONTROL SECTION */}
|
||||
|
||||
<div style={{ flex: "1 1 auto", display: "flex", justifyContent: "start", alignItems: "center", flexFlow: "row nowrap" }}>
|
||||
@@ -454,10 +447,12 @@ const PluginOutputControl =
|
||||
<div style={{ display: "flex", flexDirection: "column", width: item_width, margin: 8, height: 98 }}>
|
||||
{/* TITLE SECTION */}
|
||||
<div style={{ flex: "0 0 auto", width: "100%", marginBottom: 8, marginLeft: 0, marginRight: 0 }}>
|
||||
<ControlTooltip uiControl={control}>
|
||||
<Typography variant="caption" display="block" style={{
|
||||
width: "100%",
|
||||
textAlign: "left"
|
||||
}}> {control.name}</Typography>
|
||||
</ControlTooltip>
|
||||
</div>
|
||||
{/* CONTROL SECTION */}
|
||||
|
||||
|
||||
+6
-1
@@ -1257,7 +1257,7 @@ namespace pipedal
|
||||
{
|
||||
message =
|
||||
SS("Device " << alsa_device_name << " in use. The following applications are using your soundcard: " << apps
|
||||
<< ". Stop them as neccesary before trying to restart pipedald.");
|
||||
<< ". Stop them as neccesary before trying to pipedald.");
|
||||
}
|
||||
else
|
||||
{
|
||||
@@ -1671,12 +1671,17 @@ namespace pipedal
|
||||
pBuffer[j] = 0;
|
||||
}
|
||||
}
|
||||
try {
|
||||
while (!terminateAudio())
|
||||
{
|
||||
std::this_thread::sleep_for(std::chrono::milliseconds(10));
|
||||
// zero out input buffers.
|
||||
this->driverHost->OnProcess(this->bufferSize);
|
||||
}
|
||||
} catch (const std::exception &e)
|
||||
{
|
||||
|
||||
}
|
||||
}
|
||||
this->driverHost->OnAudioTerminated();
|
||||
}
|
||||
|
||||
+1
-1
@@ -1217,7 +1217,7 @@ private:
|
||||
}
|
||||
catch (const std::exception &e)
|
||||
{
|
||||
Lv2Log::error("Fatal error while processing jack audio. (%s)", e.what());
|
||||
Lv2Log::error("Fatal error while processing realtime audio. (%s)", e.what());
|
||||
throw;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -18,6 +18,7 @@
|
||||
// CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
|
||||
|
||||
#include "FilePropertyDirectoryTree.hpp"
|
||||
#include <filesystem>
|
||||
|
||||
using namespace pipedal;
|
||||
namespace fs = std::filesystem;
|
||||
|
||||
@@ -58,6 +58,7 @@ namespace pipedal {
|
||||
virtual bool GetRequestStateChangedNotification() const = 0;
|
||||
virtual void SetRequestStateChangedNotification(bool value) = 0;
|
||||
|
||||
virtual void PrepareNoInputEffect(int numberOfInputs, size_t maxBufferSize) = 0;
|
||||
|
||||
virtual void SetAudioInputBuffer(int index, float *buffer) = 0;
|
||||
virtual void SetAudioOutputBuffer(int index, float*buffer) = 0;
|
||||
|
||||
+114
-19
@@ -47,7 +47,6 @@ namespace fs = std::filesystem;
|
||||
|
||||
const float BYPASS_TIME_S = 0.1f;
|
||||
|
||||
|
||||
static fs::path makeAbsolutePath(const std::filesystem::path &path, const std::filesystem::path &parentPath)
|
||||
{
|
||||
if (path.is_absolute())
|
||||
@@ -57,7 +56,6 @@ static fs::path makeAbsolutePath(const std::filesystem::path &path, const std::f
|
||||
return parentPath / path;
|
||||
}
|
||||
|
||||
|
||||
Lv2Effect::Lv2Effect(
|
||||
IHost *pHost_,
|
||||
const std::shared_ptr<Lv2PluginInfo> &info_,
|
||||
@@ -112,7 +110,6 @@ Lv2Effect::Lv2Effect(
|
||||
bundleUriString,
|
||||
storagePath);
|
||||
|
||||
|
||||
mapPathFeature.Prepare(&(pHost_->GetMapFeature()));
|
||||
mapPathFeature.SetPluginStoragePath(pHost_->GetPluginStoragePath());
|
||||
if (info->piPedalUI())
|
||||
@@ -122,10 +119,8 @@ Lv2Effect::Lv2Effect(
|
||||
{
|
||||
if (!fileProperty->resourceDirectory().empty())
|
||||
{
|
||||
mapPathFeature.AddResourceFileMapping({
|
||||
makeAbsolutePath(fileProperty->resourceDirectory(),bundleUriString),
|
||||
makeAbsolutePath(fileProperty->directory(),pHost_->GetPluginStoragePath())
|
||||
});
|
||||
mapPathFeature.AddResourceFileMapping({makeAbsolutePath(fileProperty->resourceDirectory(), bundleUriString),
|
||||
makeAbsolutePath(fileProperty->directory(), pHost_->GetPluginStoragePath())});
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -145,7 +140,6 @@ Lv2Effect::Lv2Effect(
|
||||
this->features.push_back(mapPathFeature.GetMakePathFeature());
|
||||
this->features.push_back(mapPathFeature.GetFreePathFeature());
|
||||
|
||||
|
||||
this->features.push_back(this->fileBrowserFilesFeature.GetFeature());
|
||||
|
||||
this->work_schedule_feature = nullptr;
|
||||
@@ -370,16 +364,53 @@ void Lv2Effect::PreparePortIndices()
|
||||
outputAtomBuffers.resize(outputAtomPortIndices.size());
|
||||
}
|
||||
|
||||
void Lv2Effect::PrepareNoInputEffect(int numberOfInputs, size_t maxBufferSize)
|
||||
{
|
||||
if (outputAudioPortIndices.size() == 0)
|
||||
{
|
||||
// pass the input through unmodified.
|
||||
inputAudioBuffers.resize(std::max((size_t)numberOfInputs, inputAudioPortIndices.size()));
|
||||
outputAudioBuffers.resize(numberOfOutputs);
|
||||
}
|
||||
else if (inputAudioPortIndices.size() == 0)
|
||||
{
|
||||
inputAudioBuffers.resize(numberOfInputs);
|
||||
outputAudioBuffers.resize(std::max((size_t)numberOfInputs, outputAudioPortIndices.size()));
|
||||
|
||||
// allocate a working buffer which we will mix with passed-through data.
|
||||
outputMixBuffers.resize(outputAudioPortIndices.size());
|
||||
for (size_t i = 0; i < outputMixBuffers.size(); ++i)
|
||||
{
|
||||
outputMixBuffers[i].resize(maxBufferSize);
|
||||
}
|
||||
// connect the plugin to the mix buffer instead of output buffer.
|
||||
for (size_t i = 0; i < outputAudioPortIndices.size(); ++i)
|
||||
{
|
||||
int pluginIndex = this->outputAudioPortIndices[i];
|
||||
lilv_instance_connect_port(this->pInstance, pluginIndex, outputMixBuffers[i].data());
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
void Lv2Effect::SetAudioInputBuffer(int index, float *buffer)
|
||||
{
|
||||
if (index >= inputAudioPortIndices.size())
|
||||
{
|
||||
throw PiPedalArgumentException("Buffer index out of range.");
|
||||
}
|
||||
this->inputAudioBuffers[index] = buffer;
|
||||
|
||||
if (inputAudioPortIndices.size() == inputAudioBuffers.size())
|
||||
{
|
||||
int pluginIndex = this->inputAudioPortIndices[index];
|
||||
lilv_instance_connect_port(this->pInstance, pluginIndex, buffer);
|
||||
}
|
||||
else
|
||||
{
|
||||
// cases: 1->0, 1->1, 2->0, 2->1
|
||||
if (index < inputAudioPortIndices.size())
|
||||
{
|
||||
int pluginIndex = this->inputAudioPortIndices[index];
|
||||
lilv_instance_connect_port(this->pInstance, pluginIndex, buffer);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
void Lv2Effect::SetAudioInputBuffer(float *left)
|
||||
{
|
||||
@@ -388,7 +419,7 @@ void Lv2Effect::SetAudioInputBuffer(float *left)
|
||||
SetAudioInputBuffer(0, left);
|
||||
SetAudioInputBuffer(1, left);
|
||||
}
|
||||
else
|
||||
else if (GetNumberOfInputAudioPorts() != 0) /// yyx MIXING!
|
||||
{
|
||||
SetAudioInputBuffer(0, left);
|
||||
}
|
||||
@@ -400,7 +431,7 @@ void Lv2Effect::SetAudioInputBuffers(float *left, float *right)
|
||||
{
|
||||
SetAudioInputBuffer(0, left);
|
||||
}
|
||||
else
|
||||
else if (GetNumberOfInputAudioPorts() > 1)
|
||||
{
|
||||
SetAudioInputBuffer(0, left);
|
||||
SetAudioInputBuffer(1, right);
|
||||
@@ -410,9 +441,16 @@ void Lv2Effect::SetAudioInputBuffers(float *left, float *right)
|
||||
void Lv2Effect::SetAudioOutputBuffer(int index, float *buffer)
|
||||
{
|
||||
this->outputAudioBuffers[index] = buffer;
|
||||
|
||||
if (this->inputAudioPortIndices.size() != 0) // i.e. we're not mixing a zero-input control
|
||||
{
|
||||
if ((size_t)index < this->inputAudioPortIndices.size())
|
||||
{
|
||||
int pluginIndex = this->outputAudioPortIndices[index];
|
||||
lilv_instance_connect_port(pInstance, pluginIndex, buffer);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
int Lv2Effect::GetControlIndex(const std::string &key) const
|
||||
{
|
||||
@@ -452,7 +490,7 @@ void Lv2Effect::Activate()
|
||||
|
||||
void Lv2Effect::AssignUnconnectedPorts()
|
||||
{
|
||||
for (int i = 0; i < this->GetNumberOfInputAudioPorts(); ++i)
|
||||
for (size_t i = 0; i < this->inputAudioPortIndices.size(); ++i)
|
||||
{
|
||||
if (GetAudioInputBuffer(i) == nullptr)
|
||||
{
|
||||
@@ -462,14 +500,16 @@ void Lv2Effect::AssignUnconnectedPorts()
|
||||
lilv_instance_connect_port(pInstance, pluginIndex, buffer);
|
||||
}
|
||||
}
|
||||
for (int i = 0; i < this->GetNumberOfOutputAudioPorts(); ++i)
|
||||
|
||||
if (this->inputAudioPortIndices.size() != 0) // i.e. not using a mix buffer.
|
||||
{
|
||||
for (size_t i = 0; i < this->outputAudioPortIndices.size(); ++i)
|
||||
{
|
||||
if (GetAudioOutputBuffer(i) == nullptr)
|
||||
{
|
||||
int pluginIndex = this->outputAudioPortIndices[i];
|
||||
|
||||
float *buffer = bufferPool.AllocateBuffer<float>(pHost->GetMaxAudioBufferSize());
|
||||
lilv_instance_connect_port(pInstance, pluginIndex, buffer);
|
||||
int pluginIndex = this->outputAudioPortIndices[i];
|
||||
}
|
||||
}
|
||||
}
|
||||
for (int i = 0; i < this->GetNumberOfInputAtomPorts(); ++i)
|
||||
@@ -529,6 +569,61 @@ void Lv2Effect::Run(uint32_t samples, RealtimeRingBufferWriter *realtimeRingBuff
|
||||
// relay worker response
|
||||
worker->EmitResponses();
|
||||
}
|
||||
// for zero-input plugins, mix the plugin output with the input signal.
|
||||
if (this->inputAudioPortIndices.size() == 0)
|
||||
{
|
||||
|
||||
// mix a zero input controls into the output buffer using a triangular mix curve.
|
||||
float pluginLevel = std::max(1.0f, this->zeroInputMix * 2);
|
||||
float inputLevel = std::max(1.0f, (1 - this->zeroInputMix) * 2);
|
||||
|
||||
// case
|
||||
// 1 plugin output into 1 output.
|
||||
// 2 plugin outputs into 2 outputs.
|
||||
if (this->outputAudioBuffers.size() == this->outputMixBuffers.size())
|
||||
{
|
||||
for (size_t i = 0; i < this->outputMixBuffers.size(); ++i)
|
||||
{
|
||||
float *__restrict input;
|
||||
if (i >= this->inputAudioBuffers.size()) {
|
||||
if (this->inputAudioBuffers.size() == 0)
|
||||
{
|
||||
break;
|
||||
}
|
||||
input = this->inputAudioBuffers[0];
|
||||
} else {
|
||||
input = this->inputAudioBuffers[i];
|
||||
}
|
||||
float *__restrict pluginOutput = this->outputMixBuffers[i].data();
|
||||
float *__restrict finalOutput = this->outputAudioBuffers[i];
|
||||
|
||||
for (uint32_t i = 0; i < samples; ++i)
|
||||
{
|
||||
finalOutput[i] = input[i] * inputLevel + pluginOutput[i] * pluginLevel;
|
||||
}
|
||||
}
|
||||
}
|
||||
else if (this->outputAudioPortIndices.size() == 1 && this->outputAudioBuffers.size() == 2)
|
||||
{
|
||||
// 1 plugin output into 2 outputs.
|
||||
float *__restrict pluginOutput = this->outputMixBuffers[0].data();
|
||||
for (size_t i = 0; i < this->outputMixBuffers.size(); ++i)
|
||||
{
|
||||
float *__restrict input = this->inputAudioBuffers[i];
|
||||
float *__restrict finalOutput = this->outputAudioBuffers[i];
|
||||
|
||||
for (uint32_t i = 0; i < samples; ++i)
|
||||
{
|
||||
finalOutput[i] = input[i] * inputLevel + pluginOutput[i] * pluginLevel;
|
||||
}
|
||||
}
|
||||
}
|
||||
else
|
||||
{
|
||||
// e.g. 2 plugin outputs into 1 output (should never happen)
|
||||
std::runtime_error("Internal error 0xEA48");
|
||||
}
|
||||
}
|
||||
|
||||
// do soft bypass.
|
||||
if (this->bypassSamplesRemaining == 0)
|
||||
|
||||
+9
-1
@@ -193,9 +193,12 @@ namespace pipedal
|
||||
|
||||
bool requestStateChangedNotification = false;
|
||||
|
||||
float zeroInputMix = 0.5f;
|
||||
int actualAudioInputs = 0;
|
||||
int actualAudioOutputs = 0;
|
||||
std::vector<std::vector<float>> outputMixBuffers;
|
||||
void BypassTo(float value);
|
||||
|
||||
|
||||
public:
|
||||
|
||||
// non RT-thread use only.
|
||||
@@ -242,6 +245,9 @@ namespace pipedal
|
||||
bool HasErrorMessage() const { return this->hasErrorMessage; }
|
||||
const char*TakeErrorMessage() { this->hasErrorMessage = false; return this->errorMessage; }
|
||||
|
||||
virtual void PrepareNoInputEffect(int numberOfInputs,size_t maxBufferSize) override;
|
||||
|
||||
|
||||
virtual void ResetAtomBuffers();
|
||||
virtual uint64_t GetInstanceId() const { return instanceId; }
|
||||
virtual int GetNumberOfInputAudioPorts() const { return inputAudioPortIndices.size(); }
|
||||
@@ -251,6 +257,8 @@ namespace pipedal
|
||||
virtual int GetNumberOfMidiInputPorts() const { return inputMidiPortIndices.size(); }
|
||||
virtual int GetNumberOfMidiOutputPorts() const { return outputMidiPortIndices.size(); }
|
||||
|
||||
|
||||
|
||||
virtual void SetAudioInputBuffer(int index, float *buffer);
|
||||
virtual float *GetAudioInputBuffer(int index) const { return this->inputAudioBuffers[index]; }
|
||||
|
||||
|
||||
@@ -121,6 +121,7 @@ std::vector<float *> Lv2Pedalboard::PrepareItems(
|
||||
|
||||
if (pLv2Effect)
|
||||
{
|
||||
|
||||
if (pLv2Effect->HasErrorMessage())
|
||||
{
|
||||
std::string error = pLv2Effect->TakeErrorMessage();
|
||||
@@ -131,6 +132,7 @@ std::vector<float *> Lv2Pedalboard::PrepareItems(
|
||||
pEffect = pLv2Effect;
|
||||
|
||||
uint64_t instanceId = pEffect->GetInstanceId();
|
||||
pLv2Effect->PrepareNoInputEffect(inputBuffers.size(),pHost->GetMaxAudioBufferSize());
|
||||
|
||||
if (inputBuffers.size() == 1)
|
||||
{
|
||||
|
||||
+10
-1
@@ -2782,6 +2782,7 @@ void PiPedalModel::OnAlsaDriverTerminatedAbnormally() {
|
||||
Lv2Log::info("Restarting audio.");
|
||||
this->RestartAudio();
|
||||
});
|
||||
++audioRestartRetries;
|
||||
} else if (audioRestartRetries < 3)
|
||||
{
|
||||
this->audioRetryPostHandle = this->PostDelayed(
|
||||
@@ -2794,7 +2795,10 @@ void PiPedalModel::OnAlsaDriverTerminatedAbnormally() {
|
||||
|
||||
RestartAudio();
|
||||
});
|
||||
} else {
|
||||
++audioRestartRetries;
|
||||
} else if (audioRestartRetries == 3) // one attempt to start the dummy driver.
|
||||
{
|
||||
{
|
||||
this->audioRetryPostHandle = this->Post(
|
||||
// No lock to avoid deadlocks!
|
||||
[this]() {
|
||||
@@ -2802,5 +2806,10 @@ void PiPedalModel::OnAlsaDriverTerminatedAbnormally() {
|
||||
RestartAudio(true); // switch to the dummy driver.
|
||||
});
|
||||
}
|
||||
++audioRestartRetries;
|
||||
} else {
|
||||
Lv2Log::error(SS("Unable to reastart audio."));
|
||||
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
+19
-1
@@ -482,7 +482,19 @@ void PluginHost::Load(const char *lv2Path)
|
||||
Lv2PluginUiInfo info(this, plugin.get());
|
||||
if (plugin->is_valid())
|
||||
{
|
||||
#if SUPPORT_MIDI
|
||||
#if 1
|
||||
if (info.audio_inputs() > 2 || info.audio_outputs() > 2) {
|
||||
Lv2Log::debug(
|
||||
"Plugin %s (%s) skipped. %d inputs, %d outputs.", plugin->name().c_str(), plugin->uri().c_str(),
|
||||
(int)info.audio_inputs(),(int)info.audio_outputs());
|
||||
|
||||
}
|
||||
else if (info.audio_inputs() == 0 && info.audio_outputs() == 0 )
|
||||
{
|
||||
Lv2Log::debug("Plugin %s (%s) skipped. No audio i/o.", plugin->name().c_str(), plugin->uri().c_str());
|
||||
|
||||
}
|
||||
#elif SUPPORT_MIDI
|
||||
if (info.audio_inputs() == 0 && !info.has_midi_input())
|
||||
{
|
||||
Lv2Log::debug("Plugin %s (%s) skipped. No inputs.", plugin->name().c_str(), plugin->uri().c_str());
|
||||
@@ -503,6 +515,12 @@ void PluginHost::Load(const char *lv2Path)
|
||||
#endif
|
||||
else
|
||||
{
|
||||
if (info.audio_inputs() == 0) {
|
||||
Lv2Log::debug("************* ZERO INPUTS: %s (%s) skipped. No audio outputs.", plugin->name().c_str(), plugin->uri().c_str());
|
||||
}
|
||||
if (info.audio_outputs() == 0) {
|
||||
Lv2Log::debug("************* ZERO OUTPUTS: %s (%s) skipped. No audio outputs.", plugin->name().c_str(), plugin->uri().c_str());
|
||||
}
|
||||
ui_plugins_.push_back(std::move(info));
|
||||
}
|
||||
}
|
||||
|
||||
@@ -20,6 +20,7 @@
|
||||
#pragma once
|
||||
|
||||
#include <string>
|
||||
#include <filesystem>
|
||||
|
||||
namespace pipedal {
|
||||
class PiPedalModel;
|
||||
|
||||
@@ -370,6 +370,9 @@ namespace pipedal
|
||||
virtual void RequestAllPathPatchProperties() {}
|
||||
|
||||
|
||||
virtual void PrepareNoInputEffect(int numberOfInputs,size_t maxBufferSize) override {
|
||||
// do nothing.
|
||||
}
|
||||
virtual int GetNumberOfOutputAudioPorts() const
|
||||
{
|
||||
return numberOfOutputPorts;
|
||||
|
||||
@@ -27,6 +27,7 @@
|
||||
#include "json.hpp"
|
||||
#include <chrono>
|
||||
#include "UpdaterStatus.hpp"
|
||||
#include <filesystem>
|
||||
|
||||
|
||||
namespace pipedal
|
||||
|
||||
@@ -24,7 +24,7 @@
|
||||
template <typename T> class TypeDisplay;
|
||||
|
||||
#ifndef SUPPORT_MIDI // currently, only whether midi plugins can be loaded. No routing or handling implemented (yet).
|
||||
#define SUPPORT_MIDI 0
|
||||
#define SUPPORT_MIDI 1
|
||||
#endif
|
||||
|
||||
|
||||
@@ -32,33 +32,9 @@ template <typename T> class TypeDisplay;
|
||||
#include <string>
|
||||
#include <vector>
|
||||
|
||||
#include <mutex>
|
||||
#include <stdexcept>
|
||||
#include <cstdlib>
|
||||
#include <map>
|
||||
|
||||
#include <fstream>
|
||||
#include <chrono>
|
||||
#include <filesystem>
|
||||
#include <memory>
|
||||
#ifdef JUNK
|
||||
|
||||
#endif
|
||||
/*
|
||||
#include <lv2/lv2core/lv2.h>
|
||||
|
||||
#include "lv2/atom/atom.h"
|
||||
#include "lv2/atom/util.h"
|
||||
#include "lv2/log/log.h"
|
||||
#include "lv2/log/logger.h"
|
||||
#include "lv2/midi/midi.h"
|
||||
#include "lv2/urid/urid.h"
|
||||
#include "lv2/log/logger.h"
|
||||
#include "lv2/uri-map/uri-map.h"
|
||||
#include "lv2/atom/forge.h"
|
||||
#include "lv2/worker/worker.h"
|
||||
#include "lv2/patch/patch.h"
|
||||
#include "lv2/parameters/parameters.h"
|
||||
#include "lv2/units/units.h"
|
||||
*/
|
||||
#include "ss.hpp"
|
||||
|
||||
Reference in New Issue
Block a user