Handle missing plugins

fixes #24

react/public/img/fx_error.svg

@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Generator: Adobe Illustrator 16.0.0, SVG Export Plug-In . SVG Version: 6.00 Build 0)  -->
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
+<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
+	 width="48px" height="48px" viewBox="0 0 48 48" enable-background="new 0 0 48 48" xml:space="preserve">
+<g id="x">
+</g>
+<path fill="#800000" d="M41,1H7C3.687,1,1,3.687,1,7v34c0,3.313,2.687,6,6,6h34c3.313,0,6-2.688,6-6V7C47,3.687,44.313,1,41,1z
+	 M39.436,34.23l-5.205,5.205L24,29.205l-10.23,10.23L8.564,34.23L18.795,24L8.564,13.769l5.205-5.204L24,18.795l10.23-10.23
+	l5.205,5.204L29.205,24L39.436,34.23z"/>
+</svg>

react/public/var/config.json

@@ -1,7 +1,7 @@
 {
    "socket_server_port": 80,
    "socket_server_address": "*",
-
+   "debug": true,
     "max_upload_size": 1048576,
 
     "ui_plugins": [

react/src/AppThemed.tsx

@@ -476,7 +476,7 @@ const AppThemed = withStyles(appStyles)(class extends ResizeResponsiveComponent<
             // no pull-down refresh on android devices once we're ready (unless we're debug)
             let preventOverscroll =
                 this.model_.state.get() === State.Ready
-                && !this.model_.serverVersion.debug;
+                && !this.model_.debug;
 
             let overscrollBehavior = preventOverscroll ? "none" : "auto";
             document.body.style.overscrollBehavior = overscrollBehavior;
@@ -589,7 +589,7 @@ const AppThemed = withStyles(appStyles)(class extends ResizeResponsiveComponent<
                 overscrollBehavior: this.state.isDebug ? "auto" : "none"
             }}
                 onContextMenu={(e) => {
-                    if (!this.model_.serverVersion?.debug ?? false) {
+                    if (!this.model_.debug) {
                         e.preventDefault(); e.stopPropagation();
                     }
                 }}

react/src/MainPage.tsx

@@ -30,6 +30,7 @@ import Button from '@mui/material/Button';
 import InputIcon from '@mui/icons-material/Input';
 import LoadPluginDialog from './LoadPluginDialog';
 import Switch from '@mui/material/Switch';
+import Typography from '@mui/material/Typography';
 
 import PedalBoardView from './PedalBoardView';
 import { PiPedalStateError } from './PiPedalError';
@@ -314,6 +315,7 @@ export const MainPage =
                 let author = "";
                 let pluginUri = "";
                 let presetsUri = "";
+                let missing = false;
                 if (pedalBoardItem) {
                     if (pedalBoardItem.isEmpty()) {
                         title = "";
@@ -321,8 +323,9 @@ export const MainPage =
                         title = "Split";
                     } else {
                         let uiPlugin = this.model.getUiPlugin(pedalBoardItem.uri);
-                        if (uiPlugin == null) {
+                        if (!uiPlugin) {
-                            title = "Missing Plugin";
+                            missing = true;
+                            title = pedalBoardItem?.pluginName ?? "Missing plugin";
                         } else {
                             title = uiPlugin.name;
                             author = uiPlugin.author_name;
@@ -334,6 +337,23 @@ export const MainPage =
                     }
                 }
                 let classes = this.props.classes;
+                if (missing)
+                {
+                    return (
+                    <div style={{
+                        flex: "1 0 auto", overflow: "hidden", marginRight: 8,
+                        display: "flex", flexDirection: "row", flexWrap: "nowrap",
+                        alignItems: "center"
+                    }}>
+                        <div style={{ flex: "0 1 auto" }}>
+                            <span style={{ whiteSpace: "nowrap", color: "#800000" }}>
+                                <span className={classes.title}>{title}</span>
+                            </span>
+                        </div>
+                    </div>
+                    );
+                
+                } else {
                 return (
                     <div style={{
                         flex: "1 0 auto", overflow: "hidden", marginRight: 8,
@@ -357,6 +377,7 @@ export const MainPage =
                         </div>
                     </div>
                 );
+                }
             }
 
 
@@ -370,6 +391,8 @@ export const MainPage =
                 let canDelete = false;
                 let canAdd = false;
                 let instanceId = -1;
+                let missing = false;
+                let pluginUri = "#error";
 
                 if (pedalBoardItem) {
                     canDelete = pedalBoard.canDeleteItem(pedalBoardItem.instanceId);
@@ -379,11 +402,14 @@ export const MainPage =
                     } else if (pedalBoardItem.isSplit()) {
                         canAdd = true;
                     } else {
-                        uiPlugin = this.model.getUiPlugin(pedalBoardItem.uri);
+                        pluginUri = pedalBoardItem.uri;
+                        uiPlugin = this.model.getUiPlugin(pluginUri);
                         canAdd = true;
                         if (uiPlugin) {
                             bypassVisible = true;
                             bypassChecked = pedalBoardItem.isEnabled;
+                        } else {
+                            missing = true;
                         }
                     }
                 }
@@ -393,7 +419,7 @@ export const MainPage =
                     <div className={classes.frame}>
                         <div id="pedalBoardScroll" className={horizontalScrollLayout ? classes.pedalBoardScrollSmall : classes.pedalBoardScroll}
                             style={{ maxHeight: horizontalScrollLayout ? undefined : this.state.screenHeight / 2 }}>
-                            <PedalBoardView key={uiPlugin?.uri ?? "#error"} selectedId={this.state.selectedPedal}
+                            <PedalBoardView key={pluginUri} selectedId={this.state.selectedPedal}
                                 onSelectionChanged={this.onSelectionChanged}
                                 onDoubleClick={this.onPedalDoubleClick}
                                 hasTinyToolBar={this.props.hasTinyToolBar}
@@ -475,7 +501,16 @@ export const MainPage =
                         }
                         <div className={horizontalScrollLayout ? classes.controlContentSmall : classes.controlContent}>
                             {
-                                GetControlView(pedalBoardItem)
+                                missing ? (
+                                    <div style={{marginLeft: 100,marginTop: 20}}>
+                                        <Typography variant="body1" paragraph={true}>Error: Plugin is not installed.</Typography>
+                                        <Typography variant="body2"  paragraph={true}>{pluginUri}</Typography>
+                                    </div>
+
+                                ): 
+                                (
+                                      GetControlView(pedalBoardItem)
+                                )
                             }
 
                         </div>

react/src/PedalBoardView.tsx

@@ -59,6 +59,7 @@ const SVG_STEREO_STROKE_WIDTH = "6";
 
 
 const EMPTY_ICON_URL = "img/fx_empty.svg";
+const ERROR_ICON_URL = "img/fx_error.svg";
 const TERMINAL_ICON_URL = "img/fx_terminal.svg";
 
 
@@ -288,8 +289,8 @@ class PedalLayout {
             } else {
                 // default to empty plugin.
                 this.pluginType = PluginType.UtilityPlugin;
-                this.name = "#Missing";
+                this.name = pedalItem.pluginName??"#error";
-                this.iconUrl = EMPTY_ICON_URL;
+                this.iconUrl = ERROR_ICON_URL;
                 this.inputs = 2;
                 this.outputs = 2;
             }

react/src/PiPedalModel.tsx

@@ -303,6 +303,7 @@ interface ControlChangedBody {
 export interface PiPedalModel {
     clientId: number;
     countryCodes: Object;
+    debug: boolean;
     serverVersion?: PiPedalVersion;
     errorMessage: ObservableProperty<string>;
     alertMessage: ObservableProperty<string>;
@@ -721,6 +722,7 @@ class PiPedalModelImpl implements PiPedalModel {
     }
 
     maxUploadSize: number = 512 * 1024;
+    debug: boolean = false;
 
     requestConfig(): Promise<boolean> {
         const myRequest = new Request(this.varRequest('config.json'));
@@ -734,6 +736,7 @@ class PiPedalModelImpl implements PiPedalModel {
                 if (data.max_upload_size) {
                     this.maxUploadSize = data.max_upload_size;
                 }
+                this.debug = !!data.debug;
                 let { socket_server_port, socket_server_address } = data;
                 if ((!socket_server_address) || socket_server_address === "*") {
                     socket_server_address = window.location.hostname;