shawn/op-pedal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Handle Empty SampleRates Cont

Browse Source 
Prevents crashes when input/output devices report no sample rates by defaulting to the current rate or 48 kHz if needed

Provides a fallback option in the UI so the selected rate is visible even when the device list is empty
This commit is contained in:
Extremesecrecy
2025-07-23 22:14:31 -07:00
parent 69eeeca3fc
commit 85c1e46350
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
vite/src/pipedal/JackServerSettingsDialog.tsx
+2 -1
View File
@@ -520,6 +520,7 @@ const JackServerSettingsDialog = withStyles(
let sampleRates = selectedInputDevice && selectedOutputDevice ? let sampleRates = selectedInputDevice && selectedOutputDevice ?
intersectArrays(selectedInputDevice.sampleRates, selectedOutputDevice.sampleRates) intersectArrays(selectedInputDevice.sampleRates, selectedOutputDevice.sampleRates)
: (selectedInputDevice ? selectedInputDevice.sampleRates : (selectedOutputDevice ? selectedOutputDevice.sampleRates : [])); : (selectedInputDevice ? selectedInputDevice.sampleRates : (selectedOutputDevice ? selectedOutputDevice.sampleRates : []));
let sampleRateOptions = sampleRates.length === 0 ? [this.state.jackServerSettings.sampleRate || 48000] : sampleRates;
return ( return (
<DialogEx tag="jack" onClose={handleClose} aria-labelledby="select-channels-title" open={open} <DialogEx tag="jack" onClose={handleClose} aria-labelledby="select-channels-title" open={open}
@@ -589,7 +590,7 @@ const JackServerSettingsDialog = withStyles(
} }
}} }}
> >
{sampleRates.map((sr) => { {sampleRateOptions.map((sr) => {
return (<MenuItem value={sr}>{sr}</MenuItem> ); return (<MenuItem value={sr}>{sr}</MenuItem> );
})} })}
</Select> </Select>