shawn/op-pedal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Android Cilent Layout Issues

Browse Source
This commit is contained in:
Robin E. R. Davies
2025-07-14 18:13:09 -04:00
parent 890368352f
commit 818a08824c
24 changed files with 195 additions and 175 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CMakeLists.txt
+1 -1
View File
@@ -96,7 +96,7 @@ set(CPACK_PACKAGE_DESCRIPTION_SUMMARY "IoT guitar effect pedal for Raspberry Pi"
set(CPACK_DEBIAN_PACKAGE_SECTION sound) set(CPACK_DEBIAN_PACKAGE_SECTION sound)
set(CPACK_DEBIAN_PACKAGE_SHLIBDEPS ON) set(CPACK_DEBIAN_PACKAGE_SHLIBDEPS ON)
set(CPACK_DEBIAN_PACKAGE_CONTROL_STRICT_PERMISSION TRUE) set(CPACK_DEBIAN_PACKAGE_CONTROL_STRICT_PERMISSION TRUE)
set(CPACK_DEBIAN_PACKAGE_DEPENDS "lv2-dev, authbind, curl, gpg, alsa-base| pipewire, alsa-utils" ) set(CPACK_DEBIAN_PACKAGE_DEPENDS "lv2-dev, ffmpeg, authbind, curl, gpg, alsa-base| pipewire, alsa-utils" )
set(CPACK_DEBIAN_PACKAGE_ARCHITECTURE ${DEBIAN_ARCHITECTURE}) set(CPACK_DEBIAN_PACKAGE_ARCHITECTURE ${DEBIAN_ARCHITECTURE})
set(CPACK_PACKAGING_INSTALL_PREFIX /usr) set(CPACK_PACKAGING_INSTALL_PREFIX /usr)
set(CPACK_PROJECT_NAME ${PROJECT_NAME}) set(CPACK_PROJECT_NAME ${PROJECT_NAME})
_includes/gallery.html
+1 -1
View File
@@ -29,7 +29,7 @@
let galleryFrame = 0; let galleryFrame = 0;
let calculateWidth = function () { let calculateWidth = function () {
width = Math.min(maxWidth, window.innerWidth * 0.8); width = Math.min(maxWidth, document.documentElement.clientWidth * 0.8);
height = width * aspectY / aspectX; height = width * aspectY / aspectX;
frameWidth = width + borderWidth * 2; frameWidth = width + borderWidth * 2;
frameHeight = height + borderWidth * 2; frameHeight = height + borderWidth * 2;
docs/_includes/gallery.html
+1 -1
View File
@@ -34,7 +34,7 @@
let galleryFrame = 0; let galleryFrame = 0;
let calculateWidth = function () { let calculateWidth = function () {
width = Math.min(maxWidth, window.innerWidth * 0.8); width = Math.min(maxWidth, document.documentElement.clientWidth * 0.8);
height = width * aspectY / aspectX; height = width * aspectY / aspectX;
frameWidth = width + borderWidth * 2; frameWidth = width + borderWidth * 2;
frameHeight = height + borderWidth * 2; frameHeight = height + borderWidth * 2;
src/main.cpp
+17 -17
View File
@@ -82,27 +82,27 @@ static bool isJackServiceRunning()
return std::filesystem::exists(path); return std::filesystem::exists(path);
} }
#if ENABLE_BACKTRACE #if 0 && ENABLE_BACKTRACE
void segvHandler(int sig) // void segvHandler(int sig)
{ // {
void *array[10]; // void *array[10];
// Get void*'s for all entries on the stack // // Get void*'s for all entries on the stack
size_t size; // size_t size;
size = backtrace(array, 10); // size = backtrace(array, 10);
// Print out all the frames to stderr // // Print out all the frames to stderr
const char *message = "Error: SEGV signal received.\n"; // const char *message = "Error: SEGV signal received.\n";
auto _ = write(STDERR_FILENO, message, strlen(message)); // auto _ = write(STDERR_FILENO, message, strlen(message));
backtrace_symbols_fd(array + 2, size - 2, STDERR_FILENO); // backtrace_symbols_fd(array + 2, size - 2, STDERR_FILENO);
_exit(EXIT_FAILURE); // _exit(EXIT_FAILURE);
} // }
static void EnableBacktrace() // static void EnableBacktrace()
{ // {
signal(SIGSEGV, segvHandler); // signal(SIGSEGV, segvHandler);
} // }
#endif #endif
static bool TryGetLogLevel(const std::string &strLogLevel, LogLevel *result) static bool TryGetLogLevel(const std::string &strLogLevel, LogLevel *result)
todo.txt
+3 -18
View File
@@ -1,22 +1,10 @@
Persist and reconnect IP addresses in client.
Zeroconv crash assert. /var/pipedal/audio_uploads/ReverbImpulseFiles/
Magic zoom. Investigate if ((keyCode == KeyEvent.KEYCODE_BACK))
request cacheing not working.
MOD ir uses some scheme to limit the minimum buffer size, which is not implemented in Pipedal. MOD ir uses some scheme to limit the minimum buffer size, which is not implemented in Pipedal.
MOD ir layout issues.
MOD gui control should disable, not disappear.
MOD ir font (cooper-hewitt)
detect self-set control values to prevent weird jitter in mod ui levels.
ZAMEq2 Low control not working.
Modgui view should be persistent/per-plugin
Vu Meters, move rendering to background images, in order to reduce layout overhead. Vu Meters, move rendering to background images, in order to reduce layout overhead.
@@ -26,9 +14,6 @@ Remove FullScreenIME in PluginControlView.tsx
Exactly one underrun per seek in Toob Player Exactly one underrun per seek in Toob Player
Test autohotspot detection.
Ellipsis on plugin Title
check filetime conversion in gcc 12.2! (missing c++ 20 time conversion functions) check filetime conversion in gcc 12.2! (missing c++ 20 time conversion functions)
AudioFiles.cpp fileTimeToInt64 AudioFiles.cpp fileTimeToInt64
vite/index.html
+29 -8
View File
@@ -1,5 +1,6 @@
<!doctype html> <!doctype html>
<html lang="en"> <html lang="en">
<head> <head>
<meta charset="UTF-8" /> <meta charset="UTF-8" />
<link rel="icon" href="/favicon.ico" /> <link rel="icon" href="/favicon.ico" />
@@ -15,24 +16,23 @@
BODY { BODY {
background: #D0D0D0; background: #D0D0D0;
} }
</style> </style>
<style id="bgStyle"> <style id="bgStyle">
BODY { BODY {
background: #333; overscroll-behavior: "none" background: #333;
overscroll-behavior: none;
} }
</style> </style>
<script> <script>
const androidHosted = !!(window.AndroidHost); const androidHosted = !!(window.AndroidHost);
var colorScheme = localStorage.getItem("colorScheme"); var colorScheme = localStorage.getItem("colorScheme");
if (androidHosted) if (androidHosted) {
{
var hostColorScheme = window.AndroidHost.getThemePreference(); var hostColorScheme = window.AndroidHost.getThemePreference();
switch (hostColorScheme) switch (hostColorScheme) {
{
case 0: case 0:
colorScheme = "Light"; colorScheme = "Light";
break; break;
@@ -48,8 +48,8 @@
} }
} }
if (!colorScheme)
{ if (!colorScheme) {
colorScheme = "Dark"; colorScheme = "Dark";
} }
var darkMode = false; var darkMode = false;
@@ -100,13 +100,34 @@
// Run the function when the window loads // Run the function when the window loads
window.addEventListener('load', removeHashOnLoad); window.addEventListener('load', removeHashOnLoad);
function getFocusedElementBounds() {
let focusedElement = document.activeElement;
if (focusedElement && focusedElement !== document.body) {
let rect = focusedElement.getBoundingClientRect();
return {
top: rect.top,
left: rect.left,
right: rect.right,
bottom: rect.bottom,
windowWidth: window.innerWidth,
windowHeight: window.innerHeight,
};
}
return null;
}
</script> </script>
<title>PiPedal</title> <title>PiPedal</title>
</head> </head>
<body> <body>
<div id="root"></div> <div id="root"></div>
<script type="module" src="/src/main.tsx"></script> <script type="module" src="/src/main.tsx"></script>
</body> </body>
</html> </html>
vite/public/css/modGui.css
+1
View File
@@ -40,6 +40,7 @@
} }
.mod-pedal { .mod-pedal {
touch-action: none;
} }
.mod-pedal .mod-light { .mod-pedal .mod-light {
vite/src/pipedal/AutoZoom.tsx
+6 -2
View File
@@ -113,6 +113,7 @@ const AutoZoom = withStyles(
buttonPadding: number buttonPadding: number
): Rect { ): Rect {
console.log("Zoom: " + clientRect.toString() + " content: " + contentWidth + "x" + contentHeight + " buttonPadding: " + buttonPadding);
let rightButtonZoom = Math.min((clientRect.width - buttonPadding) / contentWidth, clientRect.height / contentHeight); let rightButtonZoom = Math.min((clientRect.width - buttonPadding) / contentWidth, clientRect.height / contentHeight);
let topButtonZoom = Math.min((clientRect.width - buttonPadding) / contentWidth, (clientRect.height - buttonPadding) / contentHeight); let topButtonZoom = Math.min((clientRect.width - buttonPadding) / contentWidth, (clientRect.height - buttonPadding) / contentHeight);
@@ -302,12 +303,13 @@ const AutoZoom = withStyles(
render() { render() {
const classes = withStyles.getClasses(this.props); const classes = withStyles.getClasses(this.props);
void classes; // suppress unused variable warning void classes; // suppress unused variable warning
const landscape = this.state.screenWidth > this.state.screenHeight;
return (<div style={{ overflow: "hidden", height: "100%", width: "100%" }} ref={(ref) => { this.setNormalRef(ref); }}> return (<div style={{ overflow: "hidden", height: "100%", width: "100%" }} ref={(ref) => { this.setNormalRef(ref); }}>
<div style={{ <div style={{
display: "inline-block", display: "inline-block",
position: "absolute",
visibility: this.props.contentReady ? "visible" : "hidden", visibility: this.props.contentReady ? "visible" : "hidden",
position: "relative",
}}> }}>
{!this.props.showZoomed && this.props.children} {!this.props.showZoomed && this.props.children}
</div> </div>
@@ -349,7 +351,9 @@ const AutoZoom = withStyles(
<IconButtonEx tooltip="Exit fullscreen" <IconButtonEx tooltip="Exit fullscreen"
style={{ style={{
position: "absolute", right: 16, top: 16, zIndex: 1104, position: "absolute",
right: landscape? 80: 16, // avoid potential cutout in landscape mode
top: 16, zIndex: 1104,
}} }}
onClick={(e) => { onClick={(e) => {
vite/src/pipedal/FilePropertyDialog.tsx
+1 -1
View File
@@ -246,7 +246,7 @@ export default withStyles(
this.requestScroll = true; this.requestScroll = true;
} }
getFullScreen() { getFullScreen() {
return window.innerWidth < 450 || window.innerHeight < 450; return document.documentElement.clientWidth < 450 || document.documentElement.clientHeight < 450;
} }
hProgressTimeout: number | null = null; hProgressTimeout: number | null = null;
vite/src/pipedal/FullScreenIME.tsx
+4 -4
View File
@@ -99,14 +99,14 @@ const FullScreenIME =
// because we can't determine the initial window heigth anymore. // because we can't determine the initial window heigth anymore.
if (this.currentWidth === undefined) if (this.currentWidth === undefined)
{ {
this.currentWidth = window.innerWidth; this.currentWidth = document.documentElement.clientWidth;
} }
if (this.currentWidth !== window.innerWidth) if (this.currentWidth !== document.documentElement.clientWidth)
{ {
this.validateInput(true); this.validateInput(true);
} }
// eslint-disable-next-line no-restricted-globals // eslint-disable-next-line no-restricted-globals
if (window.innerHeight >= this.props.initialHeight) { if (document.documentElement.clientHeight >= this.props.initialHeight) {
this.validateInput(true); this.validateInput(true);
} }
} }
@@ -194,7 +194,7 @@ const FullScreenIME =
this.currentWidth = undefined; this.currentWidth = undefined;
return (<div/>); return (<div/>);
} }
this.currentWidth = window.innerWidth; this.currentWidth = document.documentElement.clientWidth;
this.uiControl = control; this.uiControl = control;
vite/src/pipedal/LoadPluginDialog.tsx
+7 -7
View File
@@ -209,10 +209,10 @@ export const LoadPluginDialog =
search_string: "", search_string: "",
search_collapsed: true, search_collapsed: true,
filterType: filterType_, filterType: filterType_,
client_width: window.innerWidth, client_width: document.documentElement.clientWidth,
client_height: window.innerHeight, client_height: document.documentElement.clientHeight,
grid_cell_width: this.getCellWidth(window.innerWidth), grid_cell_width: this.getCellWidth(document.documentElement.clientWidth),
grid_cell_columns: this.getCellColumns(window.innerWidth), grid_cell_columns: this.getCellColumns(document.documentElement.clientWidth),
minimumItemWidth: props.minimumItemWidth ? props.minimumItemWidth : 220, minimumItemWidth: props.minimumItemWidth ? props.minimumItemWidth : 220,
favoritesList: this.model.favorites.get(), favoritesList: this.model.favorites.get(),
uiPlugins: this.model.ui_plugins.get() uiPlugins: this.model.ui_plugins.get()
@@ -276,9 +276,9 @@ export const LoadPluginDialog =
updateWindowSize() { updateWindowSize() {
this.setState({ this.setState({
client_width: window.innerWidth, client_width: document.documentElement.clientWidth,
client_height: window.innerHeight, client_height: document.documentElement.clientHeight,
grid_cell_width: this.getCellWidth(window.innerWidth), grid_cell_width: this.getCellWidth(document.documentElement.clientWidth),
grid_cell_columns: this.getCellColumns(window.innerWidth) grid_cell_columns: this.getCellColumns(window.innerWidth)
}); });
} }
vite/src/pipedal/MainPage.tsx
+3 -3
View File
@@ -82,7 +82,7 @@ const styles = ({ palette }: Theme) => {
}), }),
pedalboardScroll: css({ pedalboardScroll: css({
position: "relative", width: "100%", position: "relative", width: "100%",
flex: "0 0 auto", overflow: "auto", maxHeight: 220 flex: "0 0 auto", overflow: "auto", maxHeight: 220,
}), }),
pedalboardScrollSmall: css({ pedalboardScrollSmall: css({
position: "relative", width: "100%", position: "relative", width: "100%",
@@ -100,7 +100,7 @@ const styles = ({ palette }: Theme) => {
flex: "0 0 64px", width: "100%", paddingLeft: 24, paddingRight: 16, paddingBottom: 16 flex: "0 0 64px", width: "100%", paddingLeft: 24, paddingRight: 16, paddingBottom: 16
}), }),
controlContent: css({ controlContent: css({
flex: "1 1 auto", width: "100%", overflowY: "hidden", minHeight: 300 flex: "1 1 auto", width: "100%", overflowY: "hidden", minHeight: 185
}), }),
controlContentSmall: css({ controlContentSmall: css({
flex: "0 0 162px", width: "100%", height: 162, overflowY: "hidden", flex: "0 0 162px", width: "100%", height: 162, overflowY: "hidden",
@@ -145,7 +145,7 @@ export const MainPage =
model: PiPedalModel; model: PiPedalModel;
getSplitToolbar() { getSplitToolbar() {
return this.windowSize.width < SPLIT_CONTROLBAR_THRESHHOLD; return this.windowSize.width < SPLIT_CONTROLBAR_THRESHHOLD && this.windowSize.height >= HORIZONTAL_CONTROL_SCROLL_HEIGHT_BREAK;
} }
getDisplayAuthor() { getDisplayAuthor() {
if (this.getSplitToolbar()) { if (this.getSplitToolbar()) {
vite/src/pipedal/MidiBindingView.tsx
+3 -3
View File
@@ -58,13 +58,13 @@ export enum MidiControlType {
} }
export function getMidiControlType(uiPlugin: UiPlugin | undefined, symbol: string): MidiControlType { export function getMidiControlType(uiPlugin: UiPlugin | undefined, symbol: string): MidiControlType {
if (symbol === "__bypass") {
return MidiControlType.Toggle;
}
if (!uiPlugin) return MidiControlType.None; if (!uiPlugin) return MidiControlType.None;
let port = uiPlugin.getControl(symbol); let port = uiPlugin.getControl(symbol);
if (!port) return MidiControlType.None; if (!port) return MidiControlType.None;
if (symbol === "__bypass") {
return MidiControlType.Toggle;
}
if (!port) return MidiControlType.None; if (!port) return MidiControlType.None;
vite/src/pipedal/PiPedalModel.tsx
+9
View File
@@ -609,6 +609,13 @@ export class PiPedalModel //implements PiPedalModel
let message = header.message; let message = header.message;
if (message === "onControlChanged") { if (message === "onControlChanged") {
let controlChangedBody = body as ControlChangedBody; let controlChangedBody = body as ControlChangedBody;
if (body.clientId !== this.clientId) {
this.lastControlMessageWasSentbyMe = false;
}
if (this.lastControlMessageWasSentbyMe) {
return; // shortcut!
}
this._setPedalboardControlValue( this._setPedalboardControlValue(
controlChangedBody.instanceId, controlChangedBody.instanceId,
controlChangedBody.symbol, controlChangedBody.symbol,
@@ -1529,6 +1536,7 @@ export class PiPedalModel //implements PiPedalModel
} }
} }
private lastControlMessageWasSentbyMe = false;
private _setPedalboardControlValue(instanceId: number, key: string, value: number, notifyServer: boolean): void { private _setPedalboardControlValue(instanceId: number, key: string, value: number, notifyServer: boolean): void {
let pedalboard = this.pedalboard.get(); let pedalboard = this.pedalboard.get();
@@ -1547,6 +1555,7 @@ export class PiPedalModel //implements PiPedalModel
if (changed) { if (changed) {
if (notifyServer) { if (notifyServer) {
this.lastControlMessageWasSentbyMe = true;
this._setServerControl("setControl", instanceId, key, value); this._setServerControl("setControl", instanceId, key, value);
} }
this.setModelPedalboard(newPedalboard); this.setModelPedalboard(newPedalboard);
vite/src/pipedal/PluginControlView.tsx
+4 -4
View File
@@ -146,9 +146,9 @@ const styles = (theme: Theme) => createStyles({
flexDirection: "row", flexDirection: "row",
flexWrap: "nowrap", flexWrap: "nowrap",
paddingTop: "0px", paddingTop: "0px",
paddingBottom: "0px", paddingBottom: "96px",
overflowX: "hidden", overflowX: "hidden",
overflowY: "auto" overflowY: "auto",
}), }),
vuMeterL: css({ vuMeterL: css({
position: "absolute", position: "absolute",
@@ -175,7 +175,7 @@ const styles = (theme: Theme) => createStyles({
right: 0, top: 0, right: 0, top: 0,
paddingRight: 6, paddingRight: 6,
paddingLeft: 12, paddingLeft: 12,
paddingBottom: 12, // cover bottom line of a portgroup in landscape. paddingBottom: 13, // cover bottom line of a portgroup in landscape.
background: theme.mainBackground, background: theme.mainBackground,
zIndex: 3 zIndex: 3
@@ -448,7 +448,7 @@ const PluginControlView =
imeUiControl: uiControl, imeUiControl: uiControl,
imeValue: value, imeValue: value,
imeCaption: uiControl.name, imeCaption: uiControl.name,
imeInitialHeight: window.innerHeight imeInitialHeight: document.documentElement.clientHeight
}); });
} }
vite/src/pipedal/ResizeResponsiveComponent.tsx
+6 -6
View File
@@ -24,8 +24,8 @@ class ResizeResponsiveComponent<PROPS={},STATE={},S=any> extends React.Component
constructor(props: PROPS) { constructor(props: PROPS) {
super(props); super(props);
this.handleWindowResize = this.handleWindowResize.bind(this); this.handleWindowResize = this.handleWindowResize.bind(this);
this.windowSize.width = window.innerWidth; this.windowSize.width = document.documentElement.clientWidth;
this.windowSize.height = window.innerHeight; this.windowSize.height = document.documentElement.clientHeight;
} }
windowSize: {width: number,height:number} = {width: 1280, height: 1024}; windowSize: {width: number,height:number} = {width: 1280, height: 1024};
@@ -34,8 +34,8 @@ class ResizeResponsiveComponent<PROPS={},STATE={},S=any> extends React.Component
} }
handleWindowResize() { handleWindowResize() {
let width_ = window.innerWidth; let width_ = document.documentElement.clientWidth;
let height_ = window.innerHeight; let height_ = document.documentElement.clientHeight;
if (width_ !== this.windowSize.width || height_ !== this.windowSize.height) if (width_ !== this.windowSize.width || height_ !== this.windowSize.height)
{ {
this.windowSize = {width: width_, height: height_}; this.windowSize = {width: width_, height: height_};
@@ -49,8 +49,8 @@ class ResizeResponsiveComponent<PROPS={},STATE={},S=any> extends React.Component
componentDidMount() { componentDidMount() {
window.addEventListener('resize', this.handleWindowResize); window.addEventListener('resize', this.handleWindowResize);
let width_ = window.innerWidth; let width_ = document.documentElement.clientWidth;
let height_ = window.innerHeight; let height_ = document.documentElement.clientHeight;
this.windowSize = {width: width_, height: height_}; this.windowSize = {width: width_, height: height_};
this.onWindowSizeChanged(this.windowSize.width,this.windowSize.height); this.onWindowSizeChanged(this.windowSize.width,this.windowSize.height);
} }
vite/src/pipedal/SnapshotDialog.tsx
+1 -1
View File
@@ -89,7 +89,7 @@ export default class SnapshotDialog extends ResizeResponsiveComponent<SnapshotDi
} }
getFullScreen() { getFullScreen() {
return window.innerHeight < 450 || window.innerWidth < 450; return document.documentElement.clientHeight < 450 || document.documentElement.clientWidth < 450;
} }
onWindowSizeChanged(width: number, height: number): void { onWindowSizeChanged(width: number, height: number): void {
this.setState( this.setState(
vite/src/pipedal/SnapshotPanel.tsx
+4 -4
View File
@@ -123,17 +123,17 @@ export default class SnapshotPanel extends ResizeResponsiveComponent<SnapshotPan
getCollapseButtons() { getCollapseButtons() {
if (this.getPortraitOrientation()) if (this.getPortraitOrientation())
{ {
return window.innerWidth < 550; return document.documentElement.clientWidth < 550;
} else { } else {
return window.innerWidth < 800; return document.documentElement.clientWidth < 800;
} }
} }
getPortraitOrientation() { getPortraitOrientation() {
return window.innerWidth * 2 < window.innerHeight * 3; return document.documentElement.clientWidth * 2 < document.documentElement.clientHeight * 3;
} }
getLargeText() { getLargeText() {
return window.innerHeight > 700 && window.innerWidth > 1000; return document.documentElement.clientHeight > 700 && document.documentElement.clientWidth > 1000;
} }
onSaveSnapshot(index: number) { onSaveSnapshot(index: number) {
let snapshot = this.state.snapshots[index]; let snapshot = this.state.snapshots[index];
vite/src/pipedal/SnapshotPropertiesDialog.tsx
+1 -1
View File
@@ -64,7 +64,7 @@ export default class SnapshotPropertiesDialog extends ResizeResponsiveComponent<
this.state = this.stateFromProps(); this.state = this.stateFromProps();
} }
getCompactVertical() { getCompactVertical() {
return window.innerHeight < 450; return document.documentElement.clientHeight < 450;
} }
stateFromProps() { stateFromProps() {
let color = this.props.color; let color = this.props.color;
vite/src/pipedal/TextFieldEx.tsx
+1 -1
View File
@@ -52,7 +52,7 @@ const TextFieldEx = withStyles(styles, { withTheme: true })(
} }
private getUseImeMask() { private getUseImeMask() {
return this.state.androidHosted && window.innerHeight < 4500; return this.state.androidHosted && document.documentElement.clientHeight < 4500;
} }
private originalInputHref: HTMLInputElement | undefined = undefined; private originalInputHref: HTMLInputElement | undefined = undefined;
vite/src/pipedal/UseWindowSize.tsx
+2 -2
View File
@@ -25,8 +25,8 @@ import { useState, useEffect } from 'react';
const getSize = () => { const getSize = () => {
return { return {
width: window.innerWidth, width: document.documentElement.clientWidth,
height: window.innerHeight, height: document.documentElement.clientHeight,
}; };
}; };
vite/src/pipedal/Utility.tsx
+3 -3
View File
@@ -39,13 +39,13 @@ export interface ControlEntry {
const Utility = class { const Utility = class {
static isLandscape(): boolean { static isLandscape(): boolean {
return window.innerWidth > window.innerHeight; return document.documentElement.clientWidth > document.documentElement.clientHeight;
} }
static needsZoomedControls(): boolean { static needsZoomedControls(): boolean {
if (!this.isLandscape()) return false; if (!this.isLandscape()) return false;
if (window.innerHeight > 500) return false; if (document.documentElement.clientHeight > 500) return false;
if (window.innerHeight > 300) return true; if (document.documentElement.clientHeight > 300) return true;
return (('ontouchstart' in window) && return (('ontouchstart' in window) &&
((navigator.maxTouchPoints??0) > 0) ); ((navigator.maxTouchPoints??0) > 0) );
} }
vite/src/pipedal/VirtualKeyboardHandler.tsx
+1 -1
View File
@@ -51,7 +51,7 @@ export default class VirtualKeyboardHandler
enabled = false; enabled = false;
} }
this.enabled = enabled; this.enabled = enabled;
this.originalPosition = new Rectangle(0,0, window.innerWidth,window.innerHeight) this.originalPosition = new Rectangle(0,0, document.documentElement.clientWidth,document.documentElement.clientHeight)
} }
private handleVisualViewportResize(event: Event): void { private handleVisualViewportResize(event: Event): void {
const viewport = event.target as VisualViewport; const viewport = event.target as VisualViewport;
vite/src/pipedal/WindowScale.tsx
+1 -1
View File
@@ -15,7 +15,7 @@ export function getValidWindowScales(): number[]
return [1.0]; return [1.0];
} }
let result: number[] = []; let result: number[] = [];
let minDimension = Math.min(window.innerHeight,window.innerWidth); let minDimension = Math.min(document.documentElement.clientHeight,document.documentElement.clientWidth);
for (let validScale of validScales) for (let validScale of validScales)
{ {