Merge pull request #235 from rerdavies/dev

v1.3.61 merge

.github/workflows/cmake.yml

@@ -2,9 +2,11 @@ name: CMake
 
 on:
   push:
-    branches: [ main ]
+    branches: [ main, dev ]
-  pull_request:
+    paths-ignore:
-    branches: [ main ]
+      - "docs/**"
+  #pull_request:
+  #  branches: [ main ]
     
 env:
   # Customize the CMake build type here (Release, Debug, RelWithDebInfo, etc.)

CMakeLists.txt

@@ -1,10 +1,10 @@
 cmake_minimum_required(VERSION 3.16.0)
 project(pipedal 
-    VERSION 1.3.60
+    VERSION 1.3.61
     DESCRIPTION "PiPedal Guitar Effect Pedal For Raspberry Pi"
     HOMEPAGE_URL "https://rerdavies.github.io/pipedal"
 )
-set (DISPLAY_VERSION "PiPedal v1.3.60-Release")
+set (DISPLAY_VERSION "PiPedal v1.3.61-Release")
 set (PACKAGE_ARCHITECTURE "arm64")
 set (CMAKE_INSTALL_PREFIX "/usr/")
 

README.md

@@ -6,13 +6,13 @@
 <a href="https://rerdavies.github.io/pipedal/LicensePiPedal.html"><img src="https://img.shields.io/badge/MIT-MIT?label=license&color=%23808080"/></a>
 <a href="https://github.com/rerdavies/pipedal/actions"><img src="https://img.shields.io/github/actions/workflow/status/rerdavies/pipedal/cmake.yml?branch=main"/></a>
 
-Download:&nbsp;<a href='https://rerdavies.github.io/pipedal/download.html'>v1.3.60</a> 
+Download:&nbsp;<a href='https://rerdavies.github.io/pipedal/download.html'>v1.3.61</a> 
 Website:&nbsp;[https://rerdavies.github.io/pipedal](https://rerdavies.github.io/pipedal).
 Documentation:&nbsp;[https://rerdavies.github.io/pipedal/Documentation.html](https://rerdavies.github.io/pipedal/Documentation.html).
 
 &nbsp;
 
-#### NEW version 1.3.60 Release, providing [snapshots](https://rerdavies.github.io/pipedal/Snaphots.html), and a new Performance View. See the [release notes](https://rerdavies.github.io/pipedal/ReleaseNotes) for details.
+#### NEW version 1.3.61 Release, providing [snapshots](https://rerdavies.github.io/pipedal/Snaphots.html), and a new Performance View. See the [release notes](https://rerdavies.github.io/pipedal/ReleaseNotes) for details.
 
 &nbsp;
 

docs/Installing.md

@@ -13,17 +13,17 @@ page_icon: img/Install4.jpg
 
 Download the most recent Debian (.deb) package for your platform:
 
-- [Raspberry Pi OS bookworm (64-bit) v1.3.60](https://github.com/rerdavies/pipedal/releases/download/)
+- [Raspberry Pi OS bookworm (64-bit) v1.3.61](https://github.com/rerdavies/pipedal/releases/download/)
 - [Ubuntu/Raspberry Pi OS bullseyeye (64-bit) v1.2.31](https://github.com/rerdavies/pipedal/releases/download/v1.1.31/pipedal_1.1.31_arm64.deb)
 
-Version 1.3.60 has not yet been tested on Ubuntu or Raspberry Pi OS bullseye. On these platforms, we recommend that you use version 1.1.31.
+Version 1.3.61 has not yet been tested on Ubuntu or Raspberry Pi OS bullseye. On these platforms, we recommend that you use version 1.1.31.
 
 Install the package by running 
 
 ```
   sudo apt update
   cd ~/Downloads  
-  sudo apt-get install pipedal_1.3.60_arm64.deb 
+  sudo apt-get install pipedal_1.3.61_arm64.deb 
 ```
 Adjust accordingly if you have downloaded v1.1.31.
 

docs/ReleaseNotes.md

@@ -1,5 +1,11 @@
 # Release Notes
 
+## PiPedal 1.3.61 Release
+
+Bug fixes:
+- Media files are not extracted properly from preset and bank files.
+- Tuner control displayed for 3rd party tuner plugins that have outputs of type units:hz
+
 ## PiPedal 1.3.60 Release
 
 Bug fixes:

docs/UsingLv2Plugins.md

@@ -16,14 +16,14 @@ Here is a brief list of other particularly recommended plugin collections.
 
 | Collection                      | To Install                            | Description      |
 |---------------------------------|---------------------------------------|------------------|
-|[Guitarix](https://guitarix.org) ★★★☆☆ | `sudo apt install guitarix-lv2`         | A large collection of guitar amplifiers and effects. |
+| [Guitarix](https://guitarix.org) ★★★☆☆ | `sudo apt install guitarix-lv2`         | A large collection of guitar amplifiers and effects. |
-| [GxPlugins](https://github.com/brummer10/GxPlugins.lv2) ★★★★★   | [Install GxPlugsin.lv2](GxPlugins.md) | Additional amps and effects from the Guitarix collection |
+| [GxPlugins](https://github.com/brummer10/GxPlugins.lv2) ★★★★★   | `sudo apt install gxplugins` | Additional amps and effects from the Guitarix collection |
 | [MDA Plugins](http://drobilla.net/software/mda-lv2.html) ★★★★☆ | `sudo apt install mda-lv2` | 36 high-quality plugs |
 | Invada Studio Plugins ★★★☆☆         | `sudo apt install invada-studio-plugins-lv2` | Delays, distortion, filters, phaser, reverb |
-|[Zam Plugins](https://zamaudio.com) ★★★☆☆ | `sudo apt install zam-plugins`   | Filtering, EQ, and mastering effects. |
+| [Zam Plugins](https://zamaudio.com) ★★★☆☆ | `sudo apt install zam-plugins`   | Filtering, EQ, and mastering effects. |
 | [Calf Studio Gear](https:://calf-studio-gear.org) ★★★☆☆ | `sudo apt install calf-plugins` | Flanger, filters, reverb, rotary speaker &c |
-
+| [Dragonfly Reverb](https://michaelwillis.github.io/dragonfly-reverb/) ★★★☆☆ | `sudo apt install dragonfly-reverb-lv2` | Reverbs |
-The GxPlugins pack is currently distributed in source form. However, I have built a version for Raspberry Pi that can be downloaded [here](GxPlugins.md). It contains some extraordinarily beautiful amp and effect emulations, many of which are superior to plugins in the main Guitarix package.
+| [x42](https://x42-plugins.com/x42/) ★★☆☆☆ | `sudo apt install x42-plugins` |Compressors, auto-tune, tuners |
 
 For a more complete (but still incomplete) list of LV2 audio plugins, see [here](https://lv2plug.in/pages/projects.html).
 

docs/download.md

@@ -4,7 +4,7 @@
 
 Download the most recent Debian (.deb) package for your platform:
 
-- <a href="https://github.com/rerdavies/pipedal/releases/download/v1.3.60/pipedal_1.3.60_arm64.deb">Raspberry Pi OS Bookworm (64-bit) v1.3.60</a>
+- <a href="https://github.com/rerdavies/pipedal/releases/download/v1.3.61/pipedal_1.3.61_arm64.deb">Raspberry Pi OS Bookworm (64-bit) v1.3.61</a>
 
 
 Install the package by running 
@@ -12,7 +12,7 @@ Install the package by running
 ```
   sudo apt update
   cd ~/Downloads  
-  sudo apt-get install ./pipedal_1.3.60_arm64.deb
+  sudo apt-get install ./pipedal_1.3.61_arm64.deb
 ```
 
 Follow the instructions in [_Configuring PiPedal After Installation_](https://rerdavies.github.io/pipedal/Configuring.html) to complete the installation.

docs/index.md

@@ -1,7 +1,7 @@
 
 
 <img src="GithubBanner.png" width="100%"/>
-<a href="Installing.html"><i>v1.3.60</i></a>
+<a href="Installing.html"><i>v1.3.61</i></a>
 
 &nbsp;
 
@@ -9,7 +9,7 @@ To download PiPedal, click [here](download.md).
 To view PiPedal documentation, click [here](Documentation.md).
 
 
-#### NEW version 1.3.60 Release. See the [release notes](https://rerdavies.github.io/pipedal/ReleaseNotes) for details.
+#### NEW version 1.3.61 Release. See the [release notes](https://rerdavies.github.io/pipedal/ReleaseNotes) for details.
 
 &nbsp;
 

react/src/Lv2Plugin.tsx

@@ -478,7 +478,7 @@ export class UiControl implements Deserializable<UiControl> {
         this.controlType = ControlType.Dial;
 
         if (!this.is_input) {
-            if (this.units === Units.midiNote) {
+            if (this.units === Units.midiNote || this.units === Units.hz) {
                 this.controlType = ControlType.Tuner;
 
             } else if (this.units === Units.db) {

src/ZipFile.cpp

@@ -198,7 +198,12 @@ void ZipFileImpl::ExtractTo(const std::string &zipName, const std::filesystem::p
                   zip_fclose(fIn);
               }};
 
+    std::filesystem::create_directories(path.parent_path());
     std::ofstream fo{path, std::ios_base::out | std::ios_base::trunc | std::ios_base::binary};
+    if (!fo.is_open())
+    {
+        throw std::runtime_error(SS("Unable to open " << path));
+    }
 
     constexpr int BUFFER_SIZE = 64 * 1024;
     std::vector<char> vBuff(BUFFER_SIZE);