From 059922f71fb0f08fc473b6926636b4468ec59743 Mon Sep 17 00:00:00 2001
From: Extremesecrecy <10959169+extremesecrecy@users.noreply.github.com>
Date: Wed, 23 Jul 2025 22:48:22 -0700
Subject: [PATCH] Update PiPedalAlsa.cpp
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Added error checks around ALSA rate queries so that if querying the minimum rate fails, a warning is logged and 48 kHz is used as a default

When querying the maximum rate fails, the code now warns and falls back to 48 kHz; otherwise it populates valid rates and ensures a fallback if none are found

Buffer size retrieval now occurs after handling rate queries, maintaining previous behavior while supporting the new fallback logic
---
 src/PiPedalAlsa.cpp | 42 ++++++++++++++++++++++++++++++------------
 1 file changed, 30 insertions(+), 12 deletions(-)

diff --git a/src/PiPedalAlsa.cpp b/src/PiPedalAlsa.cpp
index b2f7f1a..59a2561 100644
--- a/src/PiPedalAlsa.cpp
+++ b/src/PiPedalAlsa.cpp
@@ -117,29 +117,47 @@ std::vector<AlsaDeviceInfo> PiPedalAlsaDevices::GetAlsaDevices()
                             unsigned int minRate = 0, maxRate = 0;
                             snd_pcm_uframes_t minBufferSize = 0, maxBufferSize = 0;
                             int dir;
+							
                             err = snd_pcm_hw_params_get_rate_min(params, &minRate, &dir);
-                            if (err == 0)
+                            if (err != 0)
                             {
-                                err = snd_pcm_hw_params_get_rate_max(params, &maxRate, &dir);
+                                Lv2Log::warning(SS("Failed to get minimum sample rate for device '" << info.name_ << "'. Using default 48000."));
+                                info.sampleRates_.push_back(48000);
+                                err = 0; // continue using fallback rate
                             }
-                            if (err == 0)
+                             else
                             {
-                                err = snd_pcm_hw_params_get_buffer_size_min(params, &minBufferSize);
+                                  int err2 = snd_pcm_hw_params_get_rate_max(params, &maxRate, &dir);
+                                if (err2 != 0)
+                                {
+                                    Lv2Log::warning(SS("Failed to get maximum sample rate for device '" << info.name_ << "'. Using default 48000."));
+                                    info.sampleRates_.push_back(48000);
+                                }
+                                else
+                                {
+                                    for (size_t i = 0; i < sizeof(RATES) / sizeof(RATES[0]); ++i)
+                                    {
+                                        uint32_t rate = RATES[i];
+                                        if (rate >= minRate && rate <= maxRate)
+                                        {
+                                            info.sampleRates_.push_back(rate);
+                                        }
+                                    }
+                                    if (info.sampleRates_.empty())
+                                    {
+                                        Lv2Log::warning(SS("No supported sample rates for device '" << info.name_ << "'. Using default 48000."));
+                                        info.sampleRates_.push_back(48000);
+                                    }
+                                }
                             }
+							
+							err = snd_pcm_hw_params_get_buffer_size_min(params, &minBufferSize);
                             if (err == 0)
                             {
                                 err = snd_pcm_hw_params_get_buffer_size_max(params, &maxBufferSize);
                             }
                             if (err == 0)
                             {
-                                for (size_t i = 0; i < sizeof(RATES) / sizeof(RATES[0]); ++i)
-                                {
-                                    uint32_t rate = RATES[i];
-                                    if (rate >= minRate && rate <= maxRate)
-                                    {
-                                        info.sampleRates_.push_back(rate);
-                                    }
-                                }
                                 if (minBufferSize < 16)
                                 {
                                     minBufferSize = 16;