shawn/canteen-asset-tracker
1
0
Fork 0
Code Issues 8 Pull Requests Actions Packages Projects Releases Wiki Activity

UX fixes: Map tab crash, Edit/Delete removal, help/menu copy cleanup #52

New Issue
Closed
opened 2026-05-31 00:57:54 +00:00 by shawn · 0 comments
shawn commented 2026-05-31 00:57:54 +00:00
Owner
Copy Link
Copy Source

Changes from UX review

Critical

  • Map tab crash fixed — _mapFilterTimer was used but never declared. Added let _mapFilterTimer; so applyMapFilter() doesn't throw ReferenceError. Asset pins now load.

High

  • Edit/Delete buttons removed from main app (lookup-only design). Removed HTML, edit view template, and associated JS functions. Only ✓ Check In remains on asset detail.

Medium

  • Help dialog updated — stale "Add tab" → "Find Asset tab". Removed offline mode section (features don't exist).
  • Hamburger menu — "Add / Find Asset" → "Find Asset" to match bottom nav naming.

Remaining (not fixed)

  • Make filter has duplicate entries — normalization needed but is data-level, not code.
  • "Got it" overlay re-appears — needs session persistence logic.
## Changes from UX review ### Critical - **Map tab crash fixed** — `_mapFilterTimer` was used but never declared. Added `let _mapFilterTimer;` so `applyMapFilter()` doesn't throw ReferenceError. Asset pins now load. ### High - **Edit/Delete buttons removed** from main app (lookup-only design). Removed HTML, edit view template, and associated JS functions. Only ✓ Check In remains on asset detail. ### Medium - **Help dialog updated** — stale "Add tab" → "Find Asset tab". Removed offline mode section (features don't exist). - **Hamburger menu** — "Add / Find Asset" → "Find Asset" to match bottom nav naming. ### Remaining (not fixed) - **Make filter has duplicate entries** — normalization needed but is data-level, not code. - **"Got it" overlay re-appears** — needs session persistence logic.
shawn self-assigned this 2026-05-31 00:57:54 +00:00
shawn closed this issue 2026-05-31 00:57:58 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
blocked
Kanban task is blocked
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shawn
No Assignees shawn
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shawn/canteen-asset-tracker#52
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?