shawn/canteen-asset-tracker
1
0
Fork 0
Code Issues 8 Pull Requests Actions Packages Projects Releases Wiki Activity

T1: Empty States & Onboarding — aria-hidden accessibility fix #17

New Issue
Closed
opened 2026-05-21 03:14:47 +00:00 by shawn · 0 comments
shawn commented 2026-05-21 03:14:47 +00:00
Owner
Copy Link
Copy Source

Problem

Modal overlay was not toggling aria-hidden when opening/closing, making screen readers see the modal content even when visually hidden.

Fix

  • Added aria-hidden="true" to the modal overlay in HTML
  • showModal() now sets aria-hidden="false" when opening
  • resolveModal() now sets aria-hidden="true" when closing

Commits

  • 6c1d5c3 — Main empty states & onboarding implementation
  • 1a87427 — Geofence point format fix (supports both array and object formats)
  • 845523c — aria-hidden toggle for screen reader accessibility

Verification

Browser-tested: all pages navigated, empty states verified on Customers, Dashboard, Reports, Activity Feed. Onboarding welcome overlay confirmed. No visible modal when closed.

## Problem Modal overlay was not toggling `aria-hidden` when opening/closing, making screen readers see the modal content even when visually hidden. ## Fix - Added `aria-hidden="true"` to the modal overlay in HTML - `showModal()` now sets `aria-hidden="false"` when opening - `resolveModal()` now sets `aria-hidden="true"` when closing ## Commits - 6c1d5c3 — Main empty states & onboarding implementation - 1a87427 — Geofence point format fix (supports both array and object formats) - 845523c — aria-hidden toggle for screen reader accessibility ## Verification Browser-tested: all pages navigated, empty states verified on Customers, Dashboard, Reports, Activity Feed. Onboarding welcome overlay confirmed. No visible modal when closed.
shawn closed this issue 2026-05-21 03:14:47 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
blocked
Kanban task is blocked
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shawn
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shawn/canteen-asset-tracker#17
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?